-
Notifications
You must be signed in to change notification settings - Fork 564
Bump to xamarin/java.interop/master@bd7c60a6 #4397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Draft release notes This bump appears to bring in a nice user-facing build time improvement from dotnet/java-interop@0a3354b. (Side note: The different authors between dotnet/java-interop@0a3354b and this PR makes me realize it might be useful to adjust the release note workflow to cover that scenario. At least for members of the Xamarin.Android product team, maybe each new user-facing PR in a submodule can include a PR comment with a draft release note. Then the bump in xamarin-android can combine all those comments into a For the the generator changes in this bump, it looks like they might be mostly specific to the bindings process for Thanks in advance! |
|
@jpobst for mine add: |
|
👍 Release notes added. |
Changes: dotnet/java-interop@35f30bf...a84d19e * dotnet/java-interop@a84d19e: [generator] Support //interface/@no-alternatives (#601) * dotnet/java-interop@f34ed03: [generator] Remove interface alternatives w/ interface-constants (#600) * dotnet/java-interop@c5b8aca: [CI] Specify our PR build trigger in YAML. (#598) * dotnet/java-interop@d589f1c: [Java.Interop.Tools.Cecil] use File.Exists instead of DirectoryGetFile (#596) Reduces the `<LinkAssembliesNoShrink/>` task time from about 711ms to 426ms for a small test Xamarin.Forms app on an initial clean build. Updates `generator --lang-features=interface-constants` output so that we stop emitting the `*Consts` classes in API-R. API Breakages: * `tests/api-compatibility/acceptable-breakages-v10.0.99.txt`: These are because we are no longer generating the `*Consts` types when for Default Interface Methods are enabled. * `tests/api-compatibility/acceptable-breakages-v10.0.txt`: These are because there was a bug where we were not generating `[Obsolete]` on fields that were turned into properties. Now the attribute is generated in API-28 (the "contract"), but they are no longer marked as deprecated by Google in API-29 (the "implementation"), so they appear as removing the attribute. * `tests/api-compatibility/acceptable-breakages-v8.0.txt`: As with v10.0, a "prop-ified" field was missing `[Obsolete]`, and Google later un-deprecated the field.
Breakages:
acceptable-breakages-v10.0.99.txt
These are because we are no longer generating XXXXConsts classes for DIM enabled bindings as of dotnet/java-interop#600
acceptable-breakages-v10.0.txt
These are because there was a bug where we were not generating
[Obsolete]on fields that were turned into properties. Now the attribute is generated in API-28 (the "contract"), but they are no longer marked as deprecated by Google in API-29 (the "implementation"), so they appear as removing the attribute.api-28.xml.in
api-29.xml.in
acceptable-breakages-v8.0.txt
Same as above, a propified field was missing
[Obsolete], and Google later un-deprecated the field.api-25.xml.in
api-26.xml.in