[tests] Update Mono.Android_Tests sizes #4153
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Ops, we need to update Debug and Multidex variety as well, which doesn't run on Jenkins. Let see if rerunning #4133 would get us that. |
Context: dotnet#4141 Context: dotnet@130905e Part of increase was due to splitting Java.Interop.dll into 2 assemblies, while linker didn't know about it. That was fixed by dotnet@104fe45 The remaining size increase comes from adding Java.Interop-Tests.dll and assemblies/Mono.Linq.Expressions.dll assemblies. For the record, the aps size diff: -4808 ./AndroidManifest.xml +4860 ./AndroidManifest.xml -5717 ./META-INF/ANDROIDD.SF -5609 ./META-INF/MANIFEST.MF +5989 ./META-INF/ANDROIDD.SF +5881 ./META-INF/MANIFEST.MF -185856 ./assemblies/Java.Interop.dll -115712 ./assemblies/Mono.Android-Tests.dll +77312 ./assemblies/Java.Interop-Tests.dll +6144 ./assemblies/Java.Interop.GenericMarshaler.dll +197632 ./assemblies/Java.Interop.dll +116224 ./assemblies/Mono.Android-Tests.dll -1492992 ./assemblies/Mono.Android.dll +1498624 ./assemblies/Mono.Android.dll +56320 ./assemblies/Mono.Linq.Expressions.dll -315392 ./assemblies/System.Core.dll +351232 ./assemblies/System.Core.dll -2101248 ./assemblies/mscorlib.dll +2104320 ./assemblies/mscorlib.dll -295944 ./classes.dex +303016 ./classes.dex -165328 ./lib/armeabi-v7a/libmonodroid.so +165684 ./lib/armeabi-v7a/libmonodroid.so -101908 ./lib/armeabi-v7a/libxamarin-app.so +102564 ./lib/armeabi-v7a/libxamarin-app.so -198164 ./lib/x86/libmonodroid.so +198576 ./lib/x86/libmonodroid.so -101716 ./lib/x86/libxamarin-app.so +102372 ./lib/x86/libxamarin-app.so
radekdoulik
force-pushed
the
pr-update-mono-android-tests-apk-size-reference
branch
from
7413515 to
3c9b888
Compare
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
pjcollins
approved these changes
Jan 22, 2020
pjcollins
reviewed
Jan 22, 2020
Member
pjcollins
left a comment
pjcollins
left a comment
There was a problem hiding this comment.
Actually on second thought, we may need to bump the Forms APK sizes in tests/apk-sizes-reference/TestResult-Xamarin.Forms_Tests-values-Release.csv?
/Users/runner/runners/2.164.3/work/1/s/build-tools/scripts/TestApks.targets(338,5): error : the reference 46788671 and actual size 47054371 for apk-Release-Aot differs too much (>100kb). [/Users/runner/runners/2.164.3/work/1/s/tests/Xamarin.Forms-Performance-Integration/Droid/Xamarin.Forms.Performance.Integration.Droid.csproj]
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #4141
Context: 130905e
Part of increase was due to splitting Java.Interop.dll into 2
assemblies, while linker didn't know about it. That was fixed by
104fe45
The remaining size increase comes from adding Java.Interop-Tests.dll
and assemblies/Mono.Linq.Expressions.dll assemblies.
For the record, the apk's size diff: