Build only Debug configuration of libxamarin-debug-app-helper.so #3890
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grendello
added
the
full-mono-integration-build
`libxamarin-debug-app-helper.so` is a shared library used only for Debug Xamarin.Android applications to set up the debugging environment, amongst others to copy the fast-deployed shared libraries from the override directories to an internal location where we're allowed to use `dlopen` to load the DSOs. The library used to be built twice (like our runtime), but unlike the runtime it was copied to the same location and, with Release being built second, the release version replaced the debug one resulting in a library that does not include the necessary code to set up the scenario described above. Fix the issue by building the library only in Debug configuration.
grendello
force-pushed
the
fix-debug-app-helper
branch
from
95a287a to
c1711a5
Compare
dellis1972
approved these changes
Nov 8, 2019
jonathanpeppers
approved these changes
Nov 8, 2019
Contributor
Author
|
There are two failing tests:
None of them are caused by this PR, therefore I'm going to merge - I confirmed that the new |
jonpryor
pushed a commit
that referenced
this pull request
Nov 12, 2019
`libxamarin-debug-app-helper.so` is a shared library used only for Debug Xamarin.Android applications to set up the debugging environment, amongst others to copy the fast-deployed shared libraries from the override directories to an internal location where we're allowed to use `dlopen` to load the DSOs. The library used to be built twice (like our runtime), but unlike the runtime it was copied to the same location and, with Release being built second, the release version replaced the debug one resulting in a library that does not include the necessary code to set up the scenario described above. Fix the issue by building the library only in Debug configuration.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libxamarin-debug-app-helper.sois a shared library used only for DebugXamarin.Android applications to set up the debugging environment, amongst others
to copy the fast-deployed shared libraries from the override directories to an
internal location where we're allowed to use
dlopento load the DSOs.The library used to be built twice (like our runtime), but unlike the runtime it
was copied to the same location and, with Release being built second, the
release version replaced the debug one resulting in a library that does not
include the necessary code to set up the scenario described above.
Fix the issue by building the library only in Debug configuration.