[tests] Check apk tests sizes to avoid regressions #3594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements: dotnet#3593 Added new `ProcessApkSizes` task based on `ProcessPlotInput`, which takes additional argument with apk sizes reference file. The file is used to check the current apk sizes and fails when the size difference is over a given threshold, we use 100KiB now. There's one additional threshold to warn about smalled differences, with current threshold 50KiB. The reference files can be update with > make update-apk-sizes-reference CONFIGURATION=<Debug or Release> which copies the current apk sizes files to `tests/apk-sizes-reference` directory, these are then used by `ProcessApkSizes` task. The apk sizes files were split by configuration and contain `$(Configuration)` in the name. The reason for that is an easier update of the references after failed PR build. (after the size difference is checked to be valid and desired) This way it is possible to just download the results artifacts file and copy the sizes recorded by CI build into the reference directory.
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
build |
radekdoulik
added a commit
to radekdoulik/xamarin-android
that referenced
this pull request
Jan 9, 2020
The dotnet#3594 started using different filenames, so we need to update Jenkins configuration.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements: #3593
Added new
ProcessApkSizestask based onProcessPlotInput, whichtakes additional argument with apk sizes reference file. The file is
used to check the current apk sizes and fails when the size difference
is over a given threshold, we use 100KiB now. There's one additional
threshold to warn about smalled differences, with current threshold
50KiB.
The reference files can be updated with
which copies the current apk sizes files to
tests/apk-sizes-referencedirectory, these are then used byProcessApkSizestask.The apk sizes files were split by configuration and contain
$(Configuration)in the name. The reason for that is an easierupdate of the references after failed PR build. (after the size
difference is checked to be valid and desired) This way it is possible
to just download the results artifacts file and copy the sizes
recorded by CI build into the reference directory.