[Xamarin.Android.Build.Task] Handle res-auto headerLayout #3531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/969915 Certain android resource items can make use of the following namespace xmlns:app=""http://schemas.android.com/apk/res-auto"" this provides additional extension attributes which need to be fixed up. Some examples are `actionLayout`, `rectLayout` and `roundLayout`. The values for these attributes should be lowercased as they refer to a `@layout` item. It seems however that this list is always expanding. A new item `headerLayout` seems to have appeared. Rather than handcoding each of these items, the code here changes to check for `Layout` in the attrbiute and will then lowercase the value. This should protect us from future "additions", and help our customers since they won't have to work around casing problems for attributes we do not support.
jonathanpeppers
approved these changes
Aug 21, 2019
Contributor
Author
|
BCL Test Failures are not related. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/969915
Certain android resource items can make use of the following
namespace
this provides additional extension attributes which need
to be fixed up. Some examples are
actionLayout,rectLayoutand
roundLayout. The values for these attributes shouldbe lowercased as they refer to a
@layoutitem.It seems however that this list is always expanding. A new
item
headerLayoutseems to have appeared. Rather than handcodingeach of these items, the code here changes to check for
Layoutin the attrbiute and will then lowercase the value. This should
protect us from future "additions", and help our customers since
they won't have to work around casing problems for attributes we
do not support.