[Xamarin.Android.Build.Tasks] Add EnvVar and File support for Signing APKs #3522
+140
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jonathanpeppers
left a comment
jonathanpeppers
left a comment
There was a problem hiding this comment.
Can we add a test doing combinations of:
- jarsigner vs apksigner
- file vs env var
Contributor
Author
|
@jonathanpeppers was just doing that exact thing :D |
dellis1972
force-pushed
the
Issue3513
branch
2 times, most recently
from
a7549b4 to
00042ad
Compare
mungojam
reviewed
Aug 22, 2019
… APKs. Fixes dotnet#3513 Both `jarsigner` and `apksigner` provide a way to use both files and environment variables for the store and key passwords. For `jarsigner` you have to suffix the parameter switch with either `:env` or `:file` to use those options. For `apksigner` you have to prefix the value with either `:env`, `:file` or `:pass`. We currently only support raw passwords. This commit adds support for using both `env:` and `file:` for signing. When providing values for the MSBuild properties such as `AndroidSigningStorePass` and `AndroidSigningKeyPass` all they need to do is prefix the value with `env:` or `file:` to use the alternative parameters. /p:AndroidSigningKeyPass=env:MyPasswordEnvVar /p:AndroidSigningKeyPass=file:PathToPasswordFile This will stop passwords appearing in build logs etc.
jonathanpeppers
approved these changes
Aug 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3513
Both
jarsignerandapksignerprovide a way to use bothfiles and environment variables for the store and key passwords.
For
jarsigneryou have to suffix the parameter switch with either:envor:fileto use those options. Forapksigneryou haveto prefix the value with either
:env,:fileor:pass.We currently only support raw passwords.
This commit adds support for using both
env:andfile:forsigning. When providing values for the MSBuild properties
such as
AndroidSigningStorePassandAndroidSigningKeyPassallthey need to do is prefix the value with
env:orfile:touse the alternative parameters.
This will stop passwords appearing in build logs etc.