Skip to content

[bridge] Bump bridge version to 5 as it's what mono 4.8 uses. #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[bridge] Bump bridge version to 5 as it's what mono 4.8 uses. #221

wants to merge 1 commit into from

Conversation

@kumpera
Copy link
Contributor

@kumpera kumpera commented Sep 13, 2016

@dnfclas
Copy link

dnfclas commented Sep 13, 2016

Hi @kumpera, I'm your friendly neighborhood .NET Foundation Pull Request Bot (You can call me DNFBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by .NET Foundation and real humans are currently evaluating your PR.

TTYL, DNFBOT;

@jonpryor
Copy link
Contributor

jonpryor commented Sep 14, 2016

  1. It doesn't make sense for a xamarin-android PR to "depend[] on" a monodroid PR. monodroid is private; xamarin-android is public. The dependency for that is the wrong direction.

    Consequently, this PR needs to update external/mono to the relevant mono branch+commit.

  2. Please see 67fe854 (the source of the branch conflict).

    SGEN_BRIDGE_VERSION can now be controlled by the $(MonoSgenBridgeVersion) MSBuild
    property, so in addition to updating external/mono, the
    default $(MonoSgenBridgeVersion) value should be updated,
    and the new default value documented within README.md.

@jonpryor jonpryor mentioned this pull request Sep 14, 2016
Merged
@jonpryor
Copy link
Contributor

jonpryor commented Sep 14, 2016

Superseded by: #223

@jonpryor jonpryor closed this Sep 14, 2016
radical pushed a commit that referenced this pull request May 8, 2018
@jonathanpeppers @jonpryor
[build] Fix Gendarme Download (#221)
f76b741 
Github seems to have changed their download URLs, our old URL is no
longer working:

	https://cloud.github.com/downloads/spouliot/gendarme/gendarme-2.10-bin.zip

If I go to the download page:

    https://github.com/spouliot/gendarme/downloads

The URL looks like it should now be:

    https://github.com/downloads/spouliot/gendarme/gendarme-2.10-bin.zip

However, after this it still failed due to Github wanting to redirect.
I had to add a `-L` switch to the `curl` command to allow redirects.
@jonpryor jonpryor deleted the bump_mono_to_4_8 branch June 11, 2019 21:42
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kumpera @dnfclas @jonpryor