Don't use Uri.EscapeUriString () #220
Closed
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method encodes everything, including ampersands in the query part of the URI. Instead follow advice given in dotnet@3675c5c#commitcomment-19000414 and use .OriginalString to let the caller handle encoding. Updates fix committed in 3675c5c for https://bugzilla.xamarin.com/show_bug.cgi?id=43411
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method encodes everything, including ampersands in the query
part of the URI. Instead follow advice given in
3675c5c#commitcomment-19000414
and use .OriginalString to let the caller handle encoding.
Updates fix committed in 3675c5c
for https://bugzilla.xamarin.com/show_bug.cgi?id=43411