[experimental] dim+remove armeabi #1997
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) You have to manually provide CscToolPath MSBuild property, unless you install xamarin.android.csc.dim package. 2) You have to explicitly specify AndroidEnableDefaultInterfaceMethods MSBuild property as True. 3) You have to explicitly specify LangVersion MSBuild property as "latest". When C# 8.0 becomes stable, 1) and 3) will become unnecessary. Then we should make changes to 2) as default.
They fail so far, because generator is not generating expected code yet.
…and fix test names.
It results in a bunch of build failures due to lack of metadata fixup for any API glitch so far.
There are DIMs that results in managed events and args types, but those names conflict each other (onAnimationStart/onAnimationEnd overloads for each). Therefore the new methods had to be renamed.
They result in "nonexistent" `Spliterator.OfXyz` return values, and somehow `managedReturn` fixup doesn't work for them. Disable generating them, removal of them is harmless due to `BaseStream#spliterator()`.
Starting with Android NDK r17, armeabi is *removed*, meaning that we cannot build anything with armeabi anymore. seealso: dotnet/java-interop#346
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #1939 fails JVM tests but now with this branch they pass (locally) ...