[Mono.Android] Use the faster java type name mapping #1890
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes dotnet#1831 Make sure we use the code path, which uses the `typename.*` maps. It is much faster than `JavaNativeTypeManager.ToJniName`. Tested with x86 emulator again. It saves 17ms (from 18ms to 1ms) in XA template and 26ms (from 28ms to 2ms) in XamlSamples app. So it scales well. It also decreases JIT usage. XA template: *Compiled methods* 1954 to 1880.
radekdoulik
added a commit
that referenced
this pull request
Jun 29, 2018
Fixes: #1831 Make sure we use the code path, which uses the `typename.*` maps. It is much faster than `JavaNativeTypeManager.ToJniName()`. Tested with x86 emulator again. It saves 17ms (from 18ms to 1ms) in XA template and 26ms (from 28ms to 2ms) in XamlSamples app. This change also decreases JIT usage: in the XA template app, *Compiled methods* is reduced from 1954 to 1880 methods.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1831
Make sure we use the code path, which uses the
typename.*maps. Itis much faster than
JavaNativeTypeManager.ToJniName.Tested with x86 emulator again. It saves 17ms (from 18ms to 1ms) in XA
template and 26ms (from 28ms to 2ms) in XamlSamples app. So it scales
well.
It also decreases JIT usage. XA template: Compiled methods 1954 to
1880.