[Mono.Android] ResourceIdManager.UpdateIdValues called N times #1855
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#1544 I was able to verify that my app's `Resource.UpdateIdValues` was getting invoked multiple times with VS 15.7.4: - Create a new Xamarin.Android app - Create a new Xamarin.Android library, and reference it from the app - (Optional) call `Android.Runtime.ResourceIdManager.UpdateIdValues` directly By placing a breakpoint, and/or `Log.Debug` messages, I can verify that my app's `Resource.UpdateIdValues` was being called 5 times! The issue lies in this code: if (id_initialized) return; //System.Reflection code to call Resource.UpdateIdValues() in the app id_initialized = true; While `Resource.UpdateIdValues` is being invoked, `ResourceIdManager.UpdateIdValues ()` is called recursively. `id_initialized` will not be set until after the reflection code has finished. The fix is to immediately set the flag: if (id_initialized) return; id_initialized = true; //System.Reflection code to call Resource.UpdateIdValues() in the app I was able to verify the fix in my app: - Build the app with `xabuild` - Re-add the `Log.Debug` message in my app's `Resource.UpdateIdValues` - Deploy the app with `xabuild` - Upon launch, I *now* only see 1 log message with `adb logcat` The performance impact is likely: - The reflection code would be slow in `Android.Runtime.ResourceIdManager.UpdateIdValues` - In the app's `Resource.UpdateIdValues`, mostly fields are being read and set. It *helps* to skip this, but it shouldn't be as slow as the reflection code. We should consider this for 15.8 if there is still time.
Member
Author
|
macOS build failing with network issue again, I retried it once: |
jonathanpeppers
added a commit
that referenced
this pull request
Jun 20, 2018
Fixes: #1544 I was able to verify that my app's `Resource.UpdateIdValues()` was getting invoked multiple times with VS 15.7.4: - Create a new Xamarin.Android app - Create a new Xamarin.Android library, reference it from the app - (Optional) call `Android.Runtime.ResourceIdManager.UpdateIdValues()` directly By placing a breakpoint, and/or `Log.Debug()` messages, I can verify that my app's `Resource.UpdateIdValues()` was being called 5 times! The issue lies in this code: if (id_initialized) return; //System.Reflection code to call Resource.UpdateIdValues() in the app id_initialized = true; While `Resource.UpdateIdValues()` is being invoked, `ResourceIdManager.UpdateIdValues()` is called recursively. The `id_initialized` field will not be set until after the reflection code has finished. The fix is to immediately set the flag: if (id_initialized) return; id_initialized = true; //System.Reflection code to call Resource.UpdateIdValues() in the app I was able to verify the fix in my app: - Build the app with `xabuild` - Re-add the `Log.Debug` message in my app's `Resource.UpdateIdValues()` - Deploy the app with `xabuild` - Upon launch, I *now* only see 1 log message with `adb logcat` The performance impact is likely: - The reflection code would be slow in `Android.Runtime.ResourceIdManager.UpdateIdValues()` - In the app's `Resource.UpdateIdValues()`, mostly fields are being read and set. It *helps* to skip this, but it shouldn't be as slow as the reflection code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1544
I was able to verify that my app's
Resource.UpdateIdValueswasgetting invoked multiple times with VS 15.7.4:
Android.Runtime.ResourceIdManager.UpdateIdValuesdirectly
By placing a breakpoint, and/or
Log.Debugmessages, I can verifythat my app's
Resource.UpdateIdValueswas being called 5 times!The issue lies in this code:
While
Resource.UpdateIdValuesis being invoked,ResourceIdManager.UpdateIdValues ()is called recursively.id_initializedwill not be set until after the reflection code hasfinished.
The fix is to immediately set the flag:
I was able to verify the fix in my app:
xabuildLog.Debugmessage in my app'sResource.UpdateIdValuesxabuildadb logcatThe performance impact is likely:
Android.Runtime.ResourceIdManager.UpdateIdValuesResource.UpdateIdValues, mostly fields are being readand set. It helps to skip this, but it shouldn't be as slow as the
reflection code.
We should consider this for 15.8 if there is still time.