[linker] Added PreserveJniMarshalMethods option #1745
Conversation
| <_InstantRunEnabled Condition=" '$(_InstantRunEnabled)' == '' ">False</_InstantRunEnabled> | ||
| <_AndroidBuildPropertiesCache>$(IntermediateOutputPath)build.props</_AndroidBuildPropertiesCache> | ||
|
|
||
| <JniMarshalMethods Condition=" '$(JniMarshalMethods)' == '' ">False</JniMarshalMethods> |
There was a problem hiding this comment.
By "convention" (mostly followed, but not everywhere), this property should begin with Android.
Additionally, this name doesn't convey intent. What about JNI Marshal Methods? Will this property eventually control generation as well as preservation, or just linker preservation?
Assuming we want it to control the entire jnimarshalmethod-gen.exe stack, I think we should call this $(AndroidGenerateJniMarshalMethods).
Whatever it's called, this property should also be documented in https://github.com/xamarin/xamarin-android/blob/master/Documentation/guides/BuildProcess.md.
There was a problem hiding this comment.
Updated and added property description to the https://github.com/xamarin/xamarin-android/blob/master/Documentation/guides/BuildProcess.md. Also fixed small typo in there.
This option makes preserving new marshal methods, generated by `jnimarshalmethod-gen.exe`, optional in the linker. It also introduces new `JniMarshalMethods` property to toggle building with generated marshal methods and will be used by following patches. It defaults to *False*.
radekdoulik
force-pushed
the
pr-linker-optional-preserve-marshal-methods
branch
from
3d89331 to
61a8193
Compare
2 participants
This option makes preserving new marshal methods, generated by
jnimarshalmethod-gen.exe, optional in the linker.It also introduces new
JniMarshalMethodsproperty to toggle buildingwith generated marshal methods and will be used by following
patches too. It defaults to False.