Don't attempt to build libzip on some Linux systems #168
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This currently prevents libzip from being built on Ubuntu
since that distribution has libzip in the archives and
the `make prepare` step installs the required archive.
Without this commit libzip was marked to be built but wasn't
*actually* built and that resulted in the error when building
the bootstrap tasks (output shortened):
xamarin-android/Xamarin.Android.sln (default targets) ->
(Build target) ->
xamarin-android/src/Xamarin.Android.Tools.BootstrapTasks/Xamarin.Android.Tools.BootstrapTasks.csproj (default targets) ->
14.0/bin/Microsoft.Common.targets (_CopyDeployFilesToOutputDirectoryAlways target) ->
14.0/bin/Microsoft.Common.targets: error : Cannot copy bin/Debug/lib/xbuild/Xamarin/Android/libzip.so to xamarin-android/bin/BuildDebug/libzip.so, as the source file doesn't exist.
If, for some reason (e.g. on a build-bot), one wants to ignore
the detection performed by code in this commit, one should
call {x,ms}build defining the _LinuxBuildLibZip property on
command line:
{x,ms}build /p:_LinuxBuildLibZip=true
radekdoulik
pushed a commit
to radekdoulik/xamarin-android
that referenced
this pull request
Aug 18, 2016
This currently prevents libzip from being built on Ubuntu
since that distribution has libzip in the archives and
the `make prepare` step installs the required archive.
Without this commit libzip was marked to be built but wasn't
*actually* built and that resulted in the error when building
the bootstrap tasks (output shortened):
xamarin-android/Xamarin.Android.sln (default targets) ->
(Build target) ->
xamarin-android/src/Xamarin.Android.Tools.BootstrapTasks/Xamarin.Android.Tools.BootstrapTasks.csproj (default targets) ->
14.0/bin/Microsoft.Common.targets (_CopyDeployFilesToOutputDirectoryAlways target) ->
14.0/bin/Microsoft.Common.targets: error : Cannot copy bin/Debug/lib/xbuild/Xamarin/Android/libzip.so to xamarin-android/bin/BuildDebug/libzip.so, as the source file doesn't exist.
If, for some reason (e.g. on a build-bot), one wants to ignore
the detection performed by code in this commit, one should
call {x,ms}build defining the _LinuxBuildLibZip property on
command line:
{x,ms}build /p:_LinuxBuildLibZip=true
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently prevents libzip from being built on Ubuntu
since that distribution has libzip in the archives and
the
make preparestep installs the required archive.Without this commit libzip was marked to be built but wasn't
actually built and that resulted in the error when building
the bootstrap tasks (output shortened):
xamarin-android/Xamarin.Android.sln (default targets) ->
(Build target) ->
xamarin-android/src/Xamarin.Android.Tools.BootstrapTasks/Xamarin.Android.Tools.BootstrapTasks.csproj (default targets) ->
14.0/bin/Microsoft.Common.targets (_CopyDeployFilesToOutputDirectoryAlways target) ->
14.0/bin/Microsoft.Common.targets: error : Cannot copy bin/Debug/lib/xbuild/Xamarin/Android/libzip.so to xamarin-android/bin/BuildDebug/libzip.so, as the source file doesn't exist.
If, for some reason (e.g. on a build-bot), one wants to ignore
the detection performed by code in this commit, one should
call {x,ms}build defining the _LinuxBuildLibZip property on
command line: