[tests] Enable diagnostic logging for make V=1
#1647
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The [xamarin-android Jenkins job][0] isn't green, but it's not because of any failing unit tests; 81ef825 fixed the last known unit test failure. [0]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/ This leaves us wondering: what's broken *now*? Fortunately we have logs, e.g. [build dotnet#987][1]: [1]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/987/ Resources/drawable/android_button.xml(4): error APT0000: No resource found that matches the given name (at 'drawable' with value '@drawable/AndroidPressed'). […/xamarin-android/src/Mono.Android/Test/Mono.Android-Tests.csproj] Resources/drawable/android_button.xml(4): error APT0000: No resource found that matches the given name (at 'drawable' with value '@drawable/AndroidPressed'). […/xamarin-android/src/Mono.Android/Test/Mono.Android-Tests.csproj] …/xamarin-android/build-tools/scripts/RunTests.targets(87,5): error MSB3073: The command "…/xamarin-android/build-tools/scripts/../../bin/Release/bin/xabuild …/xamarin-android/build-tools/scripts/../../src/Mono.Android/Test/Mono.Android-Tests.csproj /t:SignAndroidPackage /p:Configuration=Release /p:XAIntegratedTests=False /p:AotAssemblies=True" exited with code 1. Now we know why it's failing, we review the log file, and... There's no diagnostic output for that failing build. (Insert screaming & crying here.) Fortunately we've been able to since repro the issue (fix pending), but that's not quite the point/problem. The problem is that figuring out what went wrong with the above command would have been *much* easier if we had diagnostic output. Update the e.g. `RunApkTests` MSBuild target so that if the `$V` environment variable is not an empty string, we add `/v:diag` to `xabuild` invocations. This permits straightforward `make` use: $ make run-all-tests CONFIGURATION=Release V=1 # Unit test builds *also* produce diagnostic build output!
dellis1972
approved these changes
May 4, 2018
| <_XABuild>$(_TopDir)\bin\$(Configuration)\bin\xabuild</_XABuild> | ||
| <_XABuildProperties>/p:Configuration=$(Configuration) /p:XAIntegratedTests=$(XAIntegratedTests)</_XABuildProperties> | ||
| <_XABuildDiag Condition=" '$(V)' != '' ">/v:diag </_XABuildDiag> | ||
| <_XABuildProperties>$(_XABuildDiag)/p:Configuration=$(Configuration) /p:XAIntegratedTests=$(XAIntegratedTests)</_XABuildProperties> |
Member
There was a problem hiding this comment.
This shouldn't hold up this PR, but does it need a space?
$(_XABuildDiag)/p:Configuration=$(Configuration)
Should be:
$(_XABuildDiag) /p:Configuration=$(Configuration)
Contributor
Author
There was a problem hiding this comment.
Look at the $(_XABuildDiag) definition: it has a trailing space. Therefore, no space is needed. here.
jonathanpeppers
approved these changes
May 4, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The xamarin-android Jenkins job isn't green, but it's not because
of any failing unit tests; 81ef825 fixed the last known unit test
failure.
This leaves us wondering: what's broken now?
Fortunately we have logs, e.g. build #987:
Now we know why it's failing, we review the log file, and...
There's no diagnostic output for that failing build.
(Insert screaming & crying here.)
Fortunately we've been able to since repro the issue (fix pending),
but that's not quite the point/problem.
The problem is that figuring out what went wrong with the above
command would have been much easier if we had diagnostic output.
Update the e.g.
RunApkTestsMSBuild target so that if the$Venvironment variable is not an empty string, we add
/v:diagtoxabuildinvocations. This permits straightforwardmakeuse: