[tests] Ignore XUnit nonuapaottests category
#1630
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: dotnet#1400 Related: dotnet#1421 The mono/corefx xUnit test [`TaskSchedulerTests.GetTaskSchedulersForDebugger_ReturnsDefaultScheduler()`][0] [fails when built in Release mode][1]: [0]: https://github.com/dotnet/corefx/blob/893708a4c46047af6fb14bc0f2c33b3ca6adc527/src/System.Threading.Tasks/tests/TaskScheduler/TaskSchedulerTests.cs#L293-L301 [1]: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/980/testReport/junit/Test%20collection%20for%20System.Threading.Tasks.Tests/TaskSchedulerTests/System_Threading_Tasks_Tests_TaskSchedulerTests_GetTaskSchedulersForDebugger_ReturnsDefaultScheduler___Release/ System.NullReferenceException : Object reference not set to an instance of an object +++++++++++++++++++ STACK TRACE: at System.Threading.Tasks.Tests.TaskSchedulerTests.GetTaskSchedulersForDebugger_ReturnsDefaultScheduler () The cause is that the test grabs the `MethodInfo` for the `TaskScheduler.GetTaskSchedulersForDebugger()` method, which the linker removes -- correctly! as there are no references to it -- and the test then attempts to *invoke* the `MethodInfo`, but the `MethodInfo` is `null` (linked away!), resulting in the `NullReferenceException`. The test should be fixed, but in the meantime we can instead ignore the xUnit *category* of this test when building for Release.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1400
Related: #1421
The mono/corefx xUnit test
TaskSchedulerTests.GetTaskSchedulersForDebugger_ReturnsDefaultScheduler()fails when built in Release mode:
The cause is that the test grabs the
MethodInfofor theTaskScheduler.GetTaskSchedulersForDebugger()method, which thelinker removes -- correctly! as there are no references to it -- and
the test then attempts to invoke the
MethodInfo, but theMethodInfoisnull(linked away!), resulting in theNullReferenceException.The test should be fixed, but in the meantime we can instead ignore
the xUnit category of this test when building for Release.