Skip to content

[tests] builds from forks skip AssertCommercialBuild() tests #10445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 26, 2025
Merged

[tests] builds from forks skip AssertCommercialBuild() tests #10445

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b90646b
[tests] builds from forks skip `AssertCommercialBuild()` tests
jonathanpeppers Aug 26, 2025
9eb59ac
Update PerformanceTest.cs
jonathanpeppers Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/Utilities/BaseTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,17 +31,11 @@ public class BaseTest
/// Checks if a commercial .NET for Android is available
/// * Defaults to Assert.Ignore ()
/// </summary>
public void AssertCommercialBuild (bool fail = false)
public void AssertCommercialBuild ()
{
if (!TestEnvironment.CommercialBuildAvailable) {
var message = $"'{TestName}' requires a commercial build of .NET for Android.";
var runningOnCI = false;
bool.TryParse (Environment.GetEnvironmentVariable ("RunningOnCI"), out runningOnCI);
if (fail || runningOnCI) {
Assert.Fail (message);
} else {
Assert.Ignore (message);
}
Assert.Inconclusive (message);
}
}

Expand Down
4 changes: 4 additions & 0 deletions tests/MSBuildDeviceIntegration/Tests/PerformanceTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,8 @@ XamarinAndroidApplicationProject CreateApplicationProject ()
[Retry (Retry)]
public void Build_From_Clean_DontIncludeRestore ()
{
AssertCommercialBuild (); // If <BuildApk/> runs, this test will fail without Fast Deployment

var proj = CreateApplicationProject ();
using (var builder = CreateBuilderWithoutLogFile ()) {
builder.AutomaticNuGetRestore = false;
Expand Down Expand Up @@ -257,6 +259,8 @@ public void Build_AndroidAsset_Change ()
[Retry (Retry)]
public void Build_JLO_Change ()
{
AssertCommercialBuild (); // If <BuildApk/> runs, this test will fail without Fast Deployment

var className = "Foo";
var proj = CreateApplicationProject ();
proj.Sources.Add (new BuildItem.Source ("Foo.cs") {
Expand Down
Loading