Skip to content

Bump to dotnet/android-api-docs@d382c5bd #10045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 22, 2025
Merged

Bump to dotnet/android-api-docs@d382c5bd #10045

merged 3 commits into from
Apr 22, 2025

Conversation

@pjcollins
Copy link
Member

@pjcollins pjcollins commented Apr 16, 2025 •
edited
Loading

Brings in API docs for API Level 36.

Changes: dotnet/android-api-docs@492e524...d382c5b

@pjcollins
Copy link
Member Author

The Linux build is failing, looks like we have some file name casing conflicts:

mdoc: System.IO.DirectoryNotFoundException: Could not find a part of the path '/mnt/vss/_work/1/s/xamarin-android/external/android-api-docs/docs/xml/Android.Ranging.Ble.CS/BleCsRangingCapabilities.xml'.

@jpobst I'm not sure if this is just an mdoc issue or perhaps a discrepancy in some of our generated API 36 content that we may want to adjust? Scanning the repo briefly it looks like we may be using a mix of both Android.Ranging.Ble.CS and Android.Ranging.Ble.Cs namespaces in a couple of different places?
https://github.com/dotnet/android/blob/main/src/Mono.Android/PublicAPI/API-36/PublicAPI.Unshipped.txt#L1624-L1638

Android.Ranging.Ble.CS.BleCsRangingParams.SecurityLevel.get -> Android.Ranging.Ble.Cs.BleCsRangingCapabilitiesCsSecurityLevel
Android.Ranging.Ble.CS.BleCsRangingParams.SightType.get -> Android.Ranging.Ble.Cs.BleCsRangingParamsSightType
Android.Ranging.Ble.CS.BleCsRangingParams.WriteToParcel(Android.OS.Parcel! dest, Android.OS.ParcelableWriteFlags flags) -> void
Android.Ranging.Ble.Cs.BleCsRangingParamsLocationType
Android.Ranging.Ble.Cs.BleCsRangingParamsLocationType.Indoor = 1 -> Android.Ranging.Ble.Cs.BleCsRangingParamsLocationType
Android.Ranging.Ble.Cs.BleCsRangingParamsLocationType.Outdoor = 2 -> Android.Ranging.Ble.Cs.BleCsRangingParamsLocationType
Android.Ranging.Ble.Cs.BleCsRangingParamsLocationType.Unknown = 0 -> Android.Ranging.Ble.Cs.BleCsRangingParamsLocationType

@jpobst
Copy link
Contributor

jpobst commented Apr 16, 2025

@jpobst I'm not sure if this is just an mdoc issue or perhaps a discrepancy in some of our generated API 36 content that we may want to adjust?

Ugh, that is definitely a mistake I made in enumification. I will get a PR up today to fix that. Thanks for finding that!

@jpobst jpobst mentioned this pull request Apr 16, 2025
Merged
jonpryor pushed a commit that referenced this pull request Apr 21, 2025
@jpobst
[Mono.Android] Fix API-36 namespace capitalization error (#10046)
33763ef 
Context: #9914
Context: d5152b6
Context: #10045

In #9914 / d5152b6, we completed enumification of Android API-36 and
marked it as stable.

A bug in this is that we were not consistent with our capitalization
of the `Android.Ranging.Ble.CS` namespace:

Methods were placed in the `Android.Ranging.Ble.CS` namespace but
enums were placed in the `Android.Ranging.Ble.Cs` namespace.

Fix the following enums to have the correct "CS" namespace:

  * Android.Ranging.Ble.CS.BleCsRangingCapabilitiesCsSecurityLevel
  * Android.Ranging.Ble.CS.BleCsRangingParamsLocationType
  * Android.Ranging.Ble.CS.BleCsRangingParamsSightType
jonpryor pushed a commit that referenced this pull request Apr 21, 2025
@jpobst @jonpryor
[Mono.Android] Fix API-36 namespace capitalization error (#10046)
ffcd805 
Context: #9914
Context: d5152b6
Context: #10045

In #9914 / d5152b6, we completed enumification of Android API-36 and
marked it as stable.

A bug in this is that we were not consistent with our capitalization
of the `Android.Ranging.Ble.CS` namespace:

Methods were placed in the `Android.Ranging.Ble.CS` namespace but
enums were placed in the `Android.Ranging.Ble.Cs` namespace.

Fix the following enums to have the correct "CS" namespace:

  * Android.Ranging.Ble.CS.BleCsRangingCapabilitiesCsSecurityLevel
  * Android.Ranging.Ble.CS.BleCsRangingParamsLocationType
  * Android.Ranging.Ble.CS.BleCsRangingParamsSightType
@pjcollins pjcollins changed the title Bump android-api-docs for API 36 Bump to dotnet/android-api-docs@d382c5bd Apr 22, 2025
@pjcollins pjcollins marked this pull request as ready for review April 22, 2025 17:32
@pjcollins pjcollins requested a review from jonpryor as a code owner April 22, 2025 17:32
@pjcollins pjcollins requested a review from jpobst April 22, 2025 17:33
@pjcollins pjcollins merged commit 45a6adc into main Apr 22, 2025
57 of 59 checks passed
@pjcollins pjcollins deleted the dev/pjc/api36docimport branch April 22, 2025 19:42
@github-actions github-actions bot locked and limited conversation to collaborators May 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jonpryor jonpryor Awaiting requested review from jonpryor

1 more reviewer

@jpobst jpobst jpobst approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pjcollins @jpobst