Nullable enabled problem

[gmck]

Android application type

Android for .NET (net6.0-android, etc.)

Affected platform version

VS 2022 17.5.0 Prev 1

Description

Over the weekend I converted one of my test apps to net7.0-android33.0. I used the new project technique and then just imported everything from the old project via Add Existing Item. I initially disabled nullable and implicitUsings and then enabled nullable after getting the project to build and deploy successfully.

The only warning I couldn't get rid of was the following

if (Build.VERSION.SdkInt >= BuildVersionCodes.P)
{
                //#pragma warning disable CA1416 // Validate platform compatibility
                Window!.Attributes!.LayoutInDisplayCutoutMode = LayoutInDisplayCutoutMode.Default;
                //#pragma warning restore CA1416 // Validate platform compatibility
}

I could get rid of the pragma by using the [SupportedOSPlatformAttribute("android28.0")] attribute on the function calling the code. However, I don't understand the necessity for either, when the code is already surrounded by the correct Build.VERSION.SdkInt >= BuildVersionCodes.P condition. Why the warning?

A second problem was trying to do the equivalent of <RuntimeIdentifiers>android-arm;android-arm64;</RuntimeIdentifiers> within Application Properties - it doesn't seem possible,

Sample App https://github.com/gmck/NavigationGraph2Net7

Steps to Reproduce

See sample app

Did you find any workaround?

No

Relevant log output

No response

[jonathanpeppers]

The code analyzer that emits CA1416 has no idea about Build.VERSION.SdkInt. It is based on the OperatingSystem class:

https://github.com/dotnet/designs/blob/a447d77bb53d189746ccd80c2d814064c2b6c606/accepted/2020/platform-checks/platform-checks.md#platform-guards

So does an OperatingSystem.IsAndroidVersionAtLeast(28) check solve the problem here? I would use that anyway, as it won't have to do any interop into Java (should be faster).

Hi @gmck. We have added the "need-info" label to this issue, which indicates that we have an open question for you before we can take further action. This issue will be closed automatically in 7 days if we do not hear back from you by then - please feel free to re-open it if you come back to this issue after that time.

[gmck]

@jonathanpeppers
Thanks, Jonathon for the explanation and the source

if (OperatingSystem.IsAndroidVersionAtLeast(28)) 
    Window!.Attributes!.LayoutInDisplayCutoutMode = LayoutInDisplayCutoutMode.Default;

works fine.

[dellis1972]

@gmck can we close this one now?

[gmck]

Could you also comment on

A second problem was trying to do the equivalent of android-arm;android-arm64; within Application Properties - it doesn't seem possible.

[jonathanpeppers]

You should be able to click the project to edit the .csproj in the XML editor, and do:

<RuntimeIdentifiers Condition=" '$(Configuration)' == 'Release' ">android-arm;android-arm64</RuntimeIdentifiers>

I would only set these for Release mode, as Debug mode (Fast Deployment) will already use a single RID that works with the selected device.

If you want to suggest a feature for project options UI (the IDE), you can use:

https://developercommunity.visualstudio.com/

Thanks!