Recent AOT apk size increase vs performance

[radekdoulik]

Context: #4133 (comment)

I was analyzing the apk sizes for PR #4133 and found out the Java.Interop bump bb36e3e is adding about 370kbytes to the apk size.

Looks like the dotnet/java-interop@3b24a2c might be causing that.

@jonathanpeppers could you please measure the same app with AOT as well? To see whether the added size doesn't harm the AOT runtime performance.

[jonathanpeppers]

@radekdoulik this would probably increase AOT size. Do you want to undo this change?

[jonathanpeppers]

I tried looking at the plots, but I can't tell if it's better/worse: https://jenkins.mono-project.com/view/Xamarin.Android/job/xamarin-android/plot/Tests%20times/

I'll measure with AOT.

[jonathanpeppers]

I tested with a Blank Forms app I've been profiling in Xamarin.Forms/4.4.0: https://github.com/jonathanpeppers/Xamarin.Forms/tree/186b7a1663c9fb37b9f1da42fd5cb75224f4714b/HelloForms/HelloForms

Release build with AotAssemblies=True

Current xamarin-android/master:

01-24 11:23:22.884  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +563ms
01-24 11:23:26.844  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +511ms
01-24 11:23:30.809  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +492ms
01-24 11:23:34.814  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +491ms
01-24 11:23:38.809  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +487ms
01-24 11:23:42.794  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +488ms
01-24 11:23:46.810  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +507ms
01-24 11:23:50.809  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +492ms
01-24 11:23:54.811  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +496ms
01-24 11:23:58.842  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +499ms
Average(ms): 502.6
Std Err(ms): 7.15728067541484
Std Dev(ms): 22.6333087874192

Reverted dotnet/java-interop@3b24a2c:

01-24 11:17:38.729  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +551ms
01-24 11:17:42.660  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +498ms
01-24 11:17:46.676  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +497ms
01-24 11:17:50.710  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +486ms
01-24 11:17:54.710  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +485ms
01-24 11:17:58.729  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +491ms
01-24 11:18:02.743  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +505ms
01-24 11:18:06.749  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +493ms
01-24 11:18:10.781  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +517ms
01-24 11:18:14.762  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +499ms
Average(ms): 502.2
Std Err(ms): 6.17485942260137
Std Dev(ms): 19.5266200067725

Release build with JIT (just default settings)

Current xamarin-android/master:

01-24 11:21:23.900  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +813ms
01-24 11:21:27.835  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +757ms
01-24 11:21:31.832  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +734ms
01-24 11:21:35.853  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +746ms
01-24 11:21:39.835  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +746ms
01-24 11:21:43.850  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +737ms
01-24 11:21:47.871  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +743ms
01-24 11:21:51.900  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +744ms
01-24 11:21:55.936  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +752ms
01-24 11:21:59.886  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +737ms
Average(ms): 750.9
Std Err(ms): 7.24561169873799
Std Dev(ms): 22.9126360091738

Reverted dotnet/java-interop@3b24a2c:

01-24 11:19:23.906  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +810ms
01-24 11:19:27.875  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +758ms
01-24 11:19:31.858  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +743ms
01-24 11:19:35.911  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +742ms
01-24 11:19:39.909  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +742ms
01-24 11:19:43.926  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +745ms
01-24 11:19:47.944  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +737ms
01-24 11:19:51.928  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +745ms
01-24 11:19:55.944  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +765ms
01-24 11:19:59.910  1473  1503 I ActivityTaskManager: Displayed com.xamarin.forms.helloforms/crc6450e568c951913723.MainActivity: +736ms
Average(ms): 752.3
Std Err(ms): 7.01435036985686
Std Dev(ms): 22.1813234751922

I ran it a couple times to make sure the numbers I got here were representative.

It seems like there isn't a noticeable difference with AOT, but a 2ms difference with JIT. I was trying to improve startup for Debug builds for the devloop when I made this change.

So I guess the question is if the tradeoff is worth it or not?

[radekdoulik]

We might make it Debug only then or add AOT define and do not use it when AOT is defined? @jonp, your opinion?

[jonathanpeppers]

Our installer includes a release build of Java.Interop.dll, so I'm not sure if there is any opportunity for a #if.

What if I revisited this and only picked the top two or three calls on startup? I remember going through the profile and doing like the top 10, which are probably diminishing returns.