Skip to content

Commit 2205695

Browse files
committed
[ci] Fix maestro publishing for stable packages (#9118)
We've seen the build promotion pipeline fail when trying to publish stable package versions: error : Package 'Microsoft.iOS.Ref.net8.0_17.5' has stable version '17.5.8001' but is targeted at a non-isolated feed 'https://pkgs.dev.azure.com/dnceng/public/_packaging/dotnet8/nuget/v3/index.json' This is because we were not declaring these packages as stable when building the build asset registry manifest. Fix this by passing the `$(IsStableBuild)` property to the build asset manifest creation task. This property needs to be updated manually when switching to stable package versioning (see commit 4ea5dbb). When `$(IsStableBuild)` is set to true, packages will be pushed to an isolated feed during publishing, such as: Package [email protected] (Shipping) should go to https://pkgs.dev.azure.com/dnceng/public/_packaging/darc-pub-dotnet-android-b8317b6f/nuget/v3/index.json (Isolated, Public)
1 parent 932e6ed commit 2205695

File tree

2 files changed

+3
-0
lines changed

2 files changed

+3
-0
lines changed

Directory.Build.props

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@
3939
<AndroidPackVersionMajorMinor>$(AndroidPackVersion.Substring(0,$(AndroidPackVersionPatchIndex)))</AndroidPackVersionMajorMinor>
4040
<AndroidPackVersionPatch>$(AndroidPackVersion.Substring($([MSBuild]::Add($(AndroidPackVersionPatchIndex), 1))))</AndroidPackVersionPatch>
4141
<AndroidPackVersionSuffix>rtm</AndroidPackVersionSuffix>
42+
<IsStableBuild>false</IsStableBuild>
43+
<IsStableBuild Condition=" '$(AndroidPackVersionSuffix)' == 'rtm' ">true</IsStableBuild>
4244
</PropertyGroup>
4345

4446
<!-- Common <PackageReference/> versions -->

build-tools/create-packs/Directory.Build.targets

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -194,6 +194,7 @@
194194

195195
<PushToAzureDevOpsArtifacts
196196
ItemsToPush="@(ItemsToPush)"
197+
IsStableBuild="$(IsStableBuild)"
197198
ManifestBuildData="@(ManifestBuildData)"
198199
ManifestRepoUri="$(BUILD_REPOSITORY_NAME)"
199200
ManifestBranch="$(BUILD_SOURCEBRANCH)"

0 commit comments

Comments
 (0)