Skip to content

Commit 4ea5dbb

Browse files
[release/8.0.1xx] stable 34.0.x branding (#8361)
Context: e6002f8 The `release/8.0.1xx` versioning will be stable with .NET 8 GA. We will start out with 34.0.1, and each commit increments by 1. We have to reset `$(AndroidPackVersion)` so it will "reset" the commit distance.
1 parent fbbf984 commit 4ea5dbb

File tree

3 files changed

+8
-5
lines changed

3 files changed

+8
-5
lines changed

Directory.Build.props

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -34,8 +34,11 @@
3434
* Major/Minor match Android stable API level, such as 30.0 for API 30.
3535
* Bump first digit of the patch version for feature releases (and reset the first two digits to 0)
3636
-->
37-
<AndroidPackVersion>34.0.0</AndroidPackVersion>
38-
<AndroidPackVersionSuffix>rc.2</AndroidPackVersionSuffix>
37+
<AndroidPackVersion>34.0.1</AndroidPackVersion>
38+
<AndroidPackVersionPatchIndex>$(AndroidPackVersion.LastIndexOf("."))</AndroidPackVersionPatchIndex>
39+
<AndroidPackVersionMajorMinor>$(AndroidPackVersion.Substring(0,$(AndroidPackVersionPatchIndex)))</AndroidPackVersionMajorMinor>
40+
<AndroidPackVersionPatch>$(AndroidPackVersion.Substring($([MSBuild]::Add($(AndroidPackVersionPatchIndex), 1))))</AndroidPackVersionPatch>
41+
<AndroidPackVersionSuffix>rtm</AndroidPackVersionSuffix>
3942
</PropertyGroup>
4043

4144
<!-- Common <PackageReference/> versions -->

build-tools/create-packs/Directory.Build.targets

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@
8585
<ReplaceFileContents
8686
SourceFile="vs-workload.in.props"
8787
DestinationFile="$(XamarinAndroidSourcePath)bin\Build$(Configuration)\nuget-unsigned\vs-workload.props"
88-
Replacements="@PACK_VERSION_LONG@=$(AndroidPackVersionLong);@PACK_VERSION_SHORT@=$(AndroidMSIVersion);@WORKLOAD_VERSION@=$(AndroidMSIVersion);@VSMAN_VERSION@=$(DotNetTargetFramework)"
88+
Replacements="@PACK_VERSION_LONG@=$(AndroidPackVersionLong);@PACK_VERSION_SHORT@=$(AndroidPackVersionLong);@WORKLOAD_VERSION@=$(AndroidMSIVersion);@VSMAN_VERSION@=$(DotNetTargetFramework)"
8989
/>
9090
</Target>
9191

build-tools/scripts/XAVersionInfo.targets

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -82,8 +82,8 @@
8282
<_AndroidPackBranch>$([System.Text.RegularExpressions.Regex]::Replace('$(XAVersionBranch)', '[^a-zA-Z0-9-]', '-'))</_AndroidPackBranch>
8383
<_AndroidPackLabel Condition=" '$(_AndroidPackLabel)' == '' and ('$(XAVersionBranch)' == 'main' or $(XAVersionBranch.StartsWith('release/')))">$(AndroidPackVersionSuffix).$(PackVersionCommitCount)</_AndroidPackLabel>
8484
<_AndroidPackLabel Condition=" '$(_AndroidPackLabel)' == '' ">ci.$(_AndroidPackBranch).$(PackVersionCommitCount)</_AndroidPackLabel>
85-
<AndroidPackVersionLong>$(AndroidPackVersion)-$(_AndroidPackLabel)</AndroidPackVersionLong>
86-
<AndroidMSIVersion>$(AndroidPackVersion).$(PackVersionCommitCount)</AndroidMSIVersion>
85+
<AndroidPackVersionLong>$(AndroidPackVersionMajorMinor).$([MSBuild]::Add($(AndroidPackVersionPatch), $(PackVersionCommitCount)))</AndroidPackVersionLong>
86+
<AndroidMSIVersion>$(AndroidPackVersionLong).0</AndroidMSIVersion>
8787
</PropertyGroup>
8888
</Target>
8989
</Project>

0 commit comments

Comments
 (0)