-
Notifications
You must be signed in to change notification settings - Fork 31
Add API 29 and 30 to KnownVersions #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
For "sanity" purposes, I would prefer for starters that we not update diff --git a/src/Xamarin.Android.Tools.AndroidSdk/AndroidSdkInfo.cs b/src/Xamarin.Android.Tools.AndroidSdk/AndroidSdkInfo.cs
index 1297e51..d2d3b5f 100644
--- a/src/Xamarin.Android.Tools.AndroidSdk/AndroidSdkInfo.cs
+++ b/src/Xamarin.Android.Tools.AndroidSdk/AndroidSdkInfo.cs
@@ -98,11 +98,15 @@ namespace Xamarin.Android.Tools
public string? TryGetPlatformDirectoryFromApiLevel (string idOrApiLevel, AndroidVersions versions)
{
+ string? dir = GetPlatformDirectoryFromId (idOrApiLevel);
+ if (Directory.Exists (dir))
+ return dir;
+
var id = versions.GetIdFromApiLevel (idOrApiLevel);
if (id == null)
return null;
- string? dir = GetPlatformDirectoryFromId (id);
+ dir = GetPlatformDirectoryFromId (id);
if (Directory.Exists (dir))
return dir;and try to see how far we can get things to work w/o having |
|
@jonpryor I think the problem happens even sooner: If 29 came in here, these would both return |
|
@jonpryor I can confirm that the actual problem here is fixed in: dotnet/maui-samples#25 This is using: dotnet/android@5d1ac0a Should we merge this, or should I close it? |
| new AndroidVersion (28, "9.0", "Pie") { | ||
| AlternateIds = new[]{ "P" }, | ||
| }, | ||
| new AndroidVersion (29, "10.0", "Android X") { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Android X" was the codeName for API-29?!
I don't remember that codename…
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it is Android10?
e71d00a to
688faf0
Compare
Context: dotnet/android#4873 Although this is related to xamarin-android#4873, it is not the full fix. We probably should list the missing versions here anyway, though.
688faf0 to
4cac042
Compare
Context: dotnet/android#4873
Although this is related to dotnet/android#4873, it is not the full fix. We probably should list the missing versions here anyway, though.