Skip to content

Conversation

@jpobst
Copy link
Contributor

@jpobst jpobst commented Dec 19, 2019

  • Updates Xamarin.Android.Tools.AndroidSdk to use sdk-style projects and target netstandard2.0 and net461.
  • Update Xamarin.Android.Tools.AndroidSdk-Tests to use sdk-style projects
  • Moves Xamarin.Android.Tools.AndroidSdk-Tests into a tests directory to avoid sdk-style globbing.
  • Uses MSBuild properties for NuGet packages instead of .nuspec.
  • Updates MicroBuild.Core to Microsoft.VisualStudioEng.MicroBuild.Core.
    • Not sure what this does but the page said the old one was deprecated and pointed to the new one which supports netstandard2.0. (link)

Original package result:
original

This PR package result:
pr

@jpobst jpobst force-pushed the sdk-csproj branch 13 times, most recently from bf1a60c to 8008326 Compare December 23, 2019 17:02
@jpobst jpobst marked this pull request as ready for review December 23, 2019 17:21
@jpobst jpobst requested review from kzu and pjcollins December 23, 2019 17:21
@pjcollins
Copy link
Member

I think we'll want to kick off a https://github.com/xamarin/xamarin-android build pointing at this branch for additional testing. This may have some impact on installer creation and projects with a ProjectReference to Xamarin.Android.Tools.AndroidSdk.csproj?

@jpobst
Copy link
Contributor Author

jpobst commented Jan 8, 2020

This looks good from a xamarin-android perspective:
https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=3356690&view=results.

@kzu
Copy link
Contributor

kzu commented Jan 27, 2020

Updates MicroBuild.Core to Microsoft.VisualStudioEng.MicroBuild.Core.

This package just provides build targets, so it's TF-agnostic. We're using it in SDK-style projects and it just works. It seems to mostly be just a package rename.

@jonpryor jonpryor merged commit bfb66f3 into master Jan 28, 2020
@jpobst jpobst deleted the sdk-csproj branch February 26, 2020 16:21
jonpryor pushed a commit that referenced this pull request Feb 8, 2021
Changes: dotnet/android-libzipsharp@1.0.20...1.0.22

  * dotnet/android-libzipsharp@9f563dd: Add a test which changes the CompressionMethod of an item (#78)
  * dotnet/android-libzipsharp@3b610c9: Try actually running the tests under .net core (#77)
  * dotnet/android-libzipsharp@03cd66b: Archive the SignList.xml
  * dotnet/android-libzipsharp@8afe791: Add the signListPath parameter
  * dotnet/android-libzipsharp@ed5585c: Add SignList.xml for signing
  * dotnet/android-libzipsharp@2ab6943: Add a build_windows.bat file to make it easier to build on windows (#75)
  * …
  * dotnet/android-libzipsharp@9dca4fb: Initial commit of localisation
  * dotnet/android-libzipsharp@668babc: Add Unit Test for setting file permissions on extraction.
  * dotnet/android-libzipsharp@8f2053c: Build on Windows again (#71)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants