Avoids NRE trying to get the list of available NDK if the AndroidSdk path is null #73
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…if the AndroidSdk path is null fixes bug 938504: AndroidSdk initialization fails with a System.ArgumentNullException when no AndroidSdk is detected on the user machine https://devdiv.visualstudio.com/DevDiv/_workitems/edit/938504
Contributor
|
https://xamarinhq.slack.com/archives/C58CYJTMY/p1561656927244700 The I thus don't see why we need this PR. It might be "nice to have" -- |
Member
|
I think the more detailed error is useful. Agreed we don't need to rush it for 16.3, but I would like to see this in master and released whenever. |
jonathanpeppers
approved these changes
Aug 21, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://devdiv.visualstudio.com/DevDiv/_workitems/edit/938504