Skip to content

[Xamarin.Android.Tools.Versions] Add JavaSdkVersion #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2024
Merged

[Xamarin.Android.Tools.Versions] Add JavaSdkVersion #226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/Xamarin.Android.Tools.AndroidSdk/Xamarin.Android.Tools.Versions.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
<AndroidSdkEmulatorVersion Condition="'$(AndroidSdkEmulatorVersion)' == ''"></AndroidSdkEmulatorVersion>
<AndroidSdkPlatformVersion Condition="'$(AndroidSdkPlatformVersion)' == ''">android-34</AndroidSdkPlatformVersion>
<AndroidNdkVersion Condition="'$(AndroidNdkVersion)' == ''">26.1.10909125</AndroidNdkVersion>
<JavaSdkVersion Condition="'$(JavaSdkVersion)' == ''">17.0.8.1</JavaSdkVersion>
Copy link
Member Author

@pjcollins pjcollins Jan 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think $(JdkVersion) was also a candidate name for this property? $(JavaSdkVersion) may be a better fit, as it more closely matches the $(JavaSdkDirectory) property that can be used to specify the path to the JDK.

Copy link
Member

@jonathanpeppers jonathanpeppers Jan 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the only doc that mentions InstallAndroidDependencies:

https://github.com/dotnet/docs-maui/blob/main/docs/get-started/installation.md

I didn't make a public property for the JDK version here: https://github.com/xamarin/monodroid/commit/dbc9c67e7bd45744e5174dd7e94e5b642418bef9


<!-- obsolete; should consider removing eventually -->
<AndroidSdkToolsVersion Condition="'$(AndroidSdkToolsVersion)' == ''">26.1.1</AndroidSdkToolsVersion>
Expand Down