[Xamarin.Android.Tools.AndroidSdk] Provide more logging #170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: dotnet/android#7073 Context: https://github.com/xamarin/xamarin-android/blob/fdfc4c44ba65fcff9caf809bcf2d1f1a6837b1e3/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/AndroidDependenciesTests.cs#L19-L50 Trying to figure out how xamarin-android's `AndroidDependenciesTests.InstallAndroidDependenciesTest()` *passes*; it creates an empty "SDK" directory, then builds with the `InstallAndroidDependencies` target, and on main this works, *even though* it implies that it's creating an `AndroidSdkInfo` instance with an *empty* SDK directory: if (Directory.Exists (sdkPath)) Directory.Delete (sdkPath, true); Directory.CreateDirectory (sdkPath); // `sdkPath` is not otherwise populated Yet it *passes* `ValidateAndroidSdkLocation()`: ValidateAndroidSdkLocation: `/Users/runner/work/1/a/TestRelease/06-09_22.00.22/temp/InstallAndroidDependenciesTest/android-sdk`, result=True I do not understand *how* this can be the case, as `ValidateAndroidSdkLocation()` wants a `platform-tools/adb` program, *which should not exist*, yet it validates I am thus very confused. Expand the log messages provided by `AndroidSdkBase` & co. so that we also log "where" the `loc` parameter is coming from, via a new `locator` parameter (similar to the `locator` parameter in `JdkInfo`), and update the "file check" logic so that we log the path of the detected files. This way, hopefully, I can verify that it *is* finding an `adb`, and *where that file is located*.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#7073
Context: https://github.com/xamarin/xamarin-android/blob/fdfc4c44ba65fcff9caf809bcf2d1f1a6837b1e3/src/Xamarin.Android.Build.Tasks/Tests/Xamarin.Android.Build.Tests/AndroidDependenciesTests.cs#L19-L50
Trying to figure out how xamarin-android's
AndroidDependenciesTests.InstallAndroidDependenciesTest()passes;it creates an empty "SDK" directory, then builds with the
InstallAndroidDependenciestarget, and on main this works,even though it implies that it's creating an
AndroidSdkInfoinstance with an empty SDK directory:
Yet it passes
ValidateAndroidSdkLocation():I do not understand how this can be the case, as
ValidateAndroidSdkLocation()wants aplatform-tools/adbprogram,which should not exist, yet it validates
I am thus very confused.
Expand the log messages provided by
AndroidSdkBase& co. so thatwe also log "where" the
locparameter is coming from, via a newlocatorparameter (similar to thelocatorparameter inJdkInfo),and update the "file check" logic so that we log the path of the
detected files.
This way, hopefully, I can verify that it is finding an
adb,and where that file is located.