[Xamarin.Android.Tools.AndroidSdk] Update SDK component for API-31 #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joj
approved these changes
Sep 15, 2021
| <AndroidSdkPlatformVersion Condition="'$(AndroidSdkPlatformVersion)' == ''">android-30</AndroidSdkPlatformVersion> | ||
| <AndroidNdkVersion Condition="'$(AndroidNdkVersion)' == ''">21.3.6528147</AndroidNdkVersion> | ||
| <AndroidSdkPlatformVersion Condition="'$(AndroidSdkPlatformVersion)' == ''">android-31</AndroidSdkPlatformVersion> | ||
| <AndroidNdkVersion Condition="'$(AndroidNdkVersion)' == ''">23.0.7599858</AndroidNdkVersion> |
Member
There was a problem hiding this comment.
I don't see this version in VS 2022, is there some other place they update this list?
Contributor
There was a problem hiding this comment.
It appears the Google repository manifest is out of date and it doesn't have the released version of the NDK.
Contributor
There was a problem hiding this comment.
The latest version the SDK repo has appears to be beta4
Member
There was a problem hiding this comment.
Maybe we can just put a NDK 22.x for now?
Contributor
|
I don't think we can merge until Google will have updated their manifest. |
Context: https://dl-ssl.google.com/android/repository/repository2-1.xml Update the preferred Android SDK component versions to the current latest versions listed in the [Android Repository file][0]: * `$(AndroidSdkBuildToolsVersion)`/build-tools to 31.0.0 * `$(AndroidCommandLineToolsVersion)`/cmdline-tools to 5.0 * `$(AndroidSdkPlatformToolsVersion)`/platform-tools to 31.0.3 * `$(AndroidSdkPlatformVersion)`/platform to android-31 * `$(AndroidNdkVersion)`/ndk-bundle to 22.1.7171670 Note: there is an NDK r23 package in `ndk;23.0.7599858`, and xamarin-android supports NDK r23 as of [dotnet/android@f361d997][2], but that is installed into a *versioned* directory, a'la `$ANDROID_SDK_ROOT/ndk/23.0.7599858`, which (1) may not be fully supported, and (2) *isn't* supported by the Android SDK Manager. The latest `ndk-bundle` package is 22.1.7171670. Additionally, the Android SDK `tools` component has been [deprecated since 2017-Sep][1]. Add a comment noting that `$(AndroidSdkToolsVersion)` should be considered obsolete, and that we should eventually remove it. [0]: https://dl-ssl.google.com/android/repository/repository2-1.xml [1]: https://developer.android.com/studio/releases/sdk-tools [2]: http://github.com/xamarin/xamarin-android/commit/f361d997807504a69c29163811f362da701410b6
dellis1972
approved these changes
Sep 15, 2021
jonpryor
force-pushed
the
jonp-bump-versions-2021-09
branch
from
dcfe31f to
d53c0b5
Compare
Contributor
Author
|
Updated to prefer NDK 22.1.7171670, which is shown in #134 (comment) |
Contributor
|
It appears Google changed the NDK component name in the SDK manifest. It used to be |
grendello
approved these changes
Sep 15, 2021
jonathanpeppers
approved these changes
Sep 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://dl-ssl.google.com/android/repository/repository2-1.xml
Update the preferred Android SDK component versions to the current latest
versions listed in the Android Repository file:
$(AndroidSdkBuildToolsVersion)/build-tools to 31.0.0$(AndroidCommandLineToolsVersion)/cmdline-tools to 5.0$(AndroidSdkPlatformToolsVersion)/platform-tools to 31.0.3$(AndroidSdkPlatformVersion)/platform to android-31$(AndroidNdkVersion)/ndk-bundle to 22.1.7171670Note: there is an NDK r23 package in
ndk;23.0.7599858, andxamarin-android supports NDK r23 as of
xamarin/xamarin-android@f361d997, but that is installed into
a versioned directory, a'la
$ANDROID_SDK_ROOT/ndk/23.0.7599858,which (1) may not be fully supported, and (2) isn't supported
by the Android SDK Manager.
The latest
ndk-bundlepackage is 22.1.7171670.Additionally, the Android SDK
toolscomponent has beendeprecated since 2017-Sep. Add a comment noting that
$(AndroidSdkToolsVersion)should be considered obsolete, and thatwe should eventually remove it.