Skip to content

StrongName Microsoft.Android.Build.BaseTasks #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 19, 2021
Merged

StrongName Microsoft.Android.Build.BaseTasks #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14c40f4
StrongName Microsoft.Android.Build.BaseTasks
dellis1972 Jul 19, 2021
5886f60
Bump LibZipSharp
dellis1972 Jul 19, 2021
aa62bf3
Fix weird error about LibZipSharp
dellis1972 Jul 19, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/Microsoft.Android.Build.BaseTasks/MSBuildReferences.projitems
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
<!--Import this file in projects needing to reference Microsoft.Build.*.dll -->
<PropertyGroup>
<MSBuildPackageReferenceVersion>16.10.0</MSBuildPackageReferenceVersion>
<LibZipSharpVersion>2.0.0-alpha7</LibZipSharpVersion>
<LibZipSharpVersion>2.0.0-alpha8</LibZipSharpVersion>
<MonoUnixVersion>7.0.0-alpha8.21302.6</MonoUnixVersion>
</PropertyGroup>

Expand All @@ -15,7 +15,7 @@
<PackageReference Include="Microsoft.Build.Tasks.Core" Version="$(MSBuildPackageReferenceVersion)" />
<PackageReference Include="Microsoft.Build.Utilities.Core" Version="$(MSBuildPackageReferenceVersion)" />
<PackageReference Include="K4os.Compression.LZ4" Version="1.1.11" />
<PackageReference Include="Xamarin.Build.AsyncTask" Version="0.3.4" GeneratePathProperty="true" />
<PackageReference Include="Xamarin.Build.AsyncTask" Version="0.4.0" GeneratePathProperty="true" />
<PackageReference Include="Xamarin.LibZipSharp" Version="$(LibZipSharpVersion)" GeneratePathProperty="true" />
<PackageReference Include="Mono.Unix" Version="$(MonoUnixVersion)" GeneratePathProperty="true" />
</ItemGroup>
Expand Down
4 changes: 3 additions & 1 deletion src/Microsoft.Android.Build.BaseTasks/Microsoft.Android.Build.BaseTasks.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,13 @@
<Import Project="..\tools\BuildTasks.props" Sdk="Microsoft.DotNet.Arcade.Sdk" />

<PropertyGroup>
<TargetFramework>netstandard2.0</TargetFramework>
<TargetFrameworks>netstandard2.0;netcoreapp3.1</TargetFrameworks>
Copy link
Contributor Author

@dellis1972 dellis1972 Jul 19, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to do this to work around

error CS1705: Assembly 'Microsoft.Android.Build.BaseTasks' with identity 'Microsoft.Android.Build.BaseTasks, Version=1.0.0.0, Culture=neutral, PublicKeyToken=84e04ff9cfb79065' uses 'libZipSharp, Version=1.0.7866.25205, Culture=neutral, PublicKeyToken=276db85bc4e20efc' which has a higher version than referenced assembly 'libZipSharp' with identity 'libZipSharp, Version=1.0.7866.25201, Culture=neutral, PublicKeyToken=276db85bc4e20efc'

Which is odd. But 🤷

<RootNamespace>Microsoft.Android.Build.Tasks</RootNamespace>
<AllowUnsafeBlocks>true</AllowUnsafeBlocks>
<GenerateResxSource>true</GenerateResxSource>
<UpdateXlfOnBuild Condition=" '$(RunningOnCI)' != 'true' ">true</UpdateXlfOnBuild>
<SignAssembly>true</SignAssembly>
<AssemblyOriginatorKeyFile>..\..\product.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>

<ItemGroup>
Expand Down