[build] Move global.json file to root directory #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4454535&view=logs&jobId=f31c9f97-4411-58e7-49ac-fc73f645e6b6&j=f31c9f97-4411-58e7-49ac-fc73f645e6b6&t=35e41a6f-4381-52eb-e0f2-d95c19469a7f We're seeing a Java.Interop build attempt fail on Windows during a NuGet restore: ##[error]The nuget command failed with exit code(1) and error(D:\a\1\s\external\xamarin-android-tools\src\Microsoft.Android.Build.BaseTasks\Microsoft.Android.Build.BaseTasks.csproj(4,3): error : C:\hostedtoolcache\windows\dotnet\sdk\3.1.300\Sdks\Microsoft.DotNet.Arcade.Sdk\Sdk not found. Check that a recent enough .NET SDK is installed and/or increase the version specified in global.json. I suspect that the out of repo restore attempt is failing to find the `global.json` file next to `Microsoft.Android.Build.BaseTasks.csproj`. To fix this we can move the file to the top of the repo, next to `Xamarin.Android.Tools.sln`.
jonpryor
added a commit
to jonpryor/java.interop
that referenced
this pull request
Feb 9, 2021
Context: dotnet/android-tools#106 Will It Build?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://devdiv.visualstudio.com/DevDiv/_build/results?buildId=4454535&view=logs&jobId=f31c9f97-4411-58e7-49ac-fc73f645e6b6&j=f31c9f97-4411-58e7-49ac-fc73f645e6b6&t=35e41a6f-4381-52eb-e0f2-d95c19469a7f
We're seeing a Java.Interop build attempt fail on Windows during a NuGet
restore:
I suspect that the out of repo restore attempt is failing to find the
global.jsonfile next toMicrosoft.Android.Build.BaseTasks.csproj.To fix this we can move the file to the top of the repo, next to
Xamarin.Android.Tools.sln.