[ci] Update packageSources in NuGet.config #105
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://medium.com/@alex.birsan/dependency-confusion-4a5d60fec610
Context: https://azure.microsoft.com/en-us/resources/3-ways-to-mitigate-risk-using-private-package-feeds/
Context: https://devdiv.visualstudio.com/DevDiv/_wiki/wikis/DevDiv.wiki/12676/ncident-help-for-Substitution-attack-risk-from-multiple-package-feeds
There is a Package Substitution Attack inherent in NuGet, whereby
if multiple package sources provide packages with the same name,
it is indeterminate which package source will provide the package.
For example, consider the
XliffTaskspackage, currentlyprovided from the
dotnet-engfeed, and not present in theNuGet.org feed. If a "hostile attacker" submits an
XliffTaskspackage to NuGet.org, then we don't know, and cannot control, whether
the build will use the "hostile"
XliffTaskspackage from NuGet.orgor the "desired" package from
dotnet-eng.There are two ways to prevent this attack:
Use
//packageSources/clearand have only one//packageSources/addentry inNuGet.configUse
//packageSources/clearand fully trust every//packageSources/addentry inNuGet.config.NuGet.orgcannot be a trusted source, nor can any feedlocation which allows "anyone" to add new packages, nor can
a feed which itself contains upstream sources.
As the
XliffTaskspackage is not inNuGet.org, option (1)isn't an option. Go with option (2), using the existing
dotnet-engsource and the new trusteddotnet-publicpackage source.