Skip to content

Fix as.exe crash on Windows #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 26, 2024
Merged

Fix as.exe crash on Windows #20

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
df9ddb1
printf the hell out of it, ongoing
grendello Mar 19, 2024
c5e3942
Custom command line parser
grendello Mar 21, 2024
c37ae93
[WIP] Migration to std::wstring and wchar_t on Windows side
grendello Mar 22, 2024
90de450
Builds, but fails to work properly
grendello Mar 25, 2024
8cd2c8a
Passing `/utf-8` to MSVC appears to have fixed the issue...
grendello Mar 26, 2024
90530f1
Fix macOS build
grendello Mar 26, 2024
aaebc67
More macOS fixes
grendello Mar 26, 2024
6f36d3c
More macOS fixes (builds locally...)
grendello Mar 26, 2024
57163b7
How about this, AppleClang 13?
grendello Mar 26, 2024
baf55ae
OK, let's see if that works
grendello Mar 26, 2024
808b958
Address feedback
grendello Mar 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,7 @@ else() # UNIX
/guard:cf
/Zi
/W3
/utf-8
)

set(COMMON_LINKER_ARGS
Expand Down Expand Up @@ -213,6 +214,7 @@ add_link_options("$<$<COMPILE_LANGUAGE:CXX>:${XA_UTILS_CXX_LINKER_FLAGS}>")
add_link_options("$<$<COMPILE_LANGUAGE:C>:${XA_UTILS_C_LINKER_FLAGS}>")

if(WIN32)
add_compile_definitions(_UNICODE)
include_directories(compat)
endif()

Expand Down
Loading