Partially revert 9d342d5057 #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: #10 Context: 9d342d5 Context: dotnet/android#8806 (comment) Revert the portion of 9d342d5 which modified the way command-line arguments are parsed. The `cxxopt` C++ library that was used turns out not to support some GNU-style options (e.g. `-mfpu=vpf3`) which breaks the MonoAOT compiler that uses them. Instead, copy `getopt.c` (BSD 2-clause + MIT/X11 licenses) and `getopt.h` (Public Domain license) implementations from the MinGW project and use `getopt` across all platforms. Additionally, fix generation of the artifact package by making sure that all the executable files are, in fact, executable by setting the correct permissions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: #10
Context: 9d342d5
Context: dotnet/android#8806 (comment)
Revert the portion of 9d342d5 which modified the way command-line
arguments are parsed. The
cxxoptC++ library that was used turns outnot to support some GNU-style options (e.g.
-mfpu=vpf3) which breaksthe MonoAOT compiler that uses them.
Instead, copy
getopt.c(BSD 2-clause + MIT/X11 licenses) andgetopt.h(Public Domain license) implementations from the MinGWproject and use
getoptacross all platforms.Additionally, fix generation of the artifact package by making sure that
all the executable files are, in fact, executable by setting the correct
permissions.