Switch back to zlib instead of zlib-ng #95
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
approved these changes
Jun 9, 2021
Context: dotnet/android#5971 (comment) Context: dotnet/android#5971 (comment) Context: zlib-ng/zlib-ng#850 Context: https://github.com/zlib-ng/zlib-ng/wiki/Deflate-config-comparison `zlib-ng` is mostly about speed and efficiency, however it achieves its goal by sometimes sacrificing the compression ratio which then affects Xamarin.Android, the main LibZipSharp consumer. Add a new `zlib` submodule and switch to using `zlib` by default instead of `zlib-ng`, while retaining `zlib-ng` as an option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: dotnet/android#5971 (comment)
Context: dotnet/android#5971 (comment)
Context: zlib-ng/zlib-ng#850
Context: https://github.com/zlib-ng/zlib-ng/wiki/Deflate-config-comparison
zlib-ngis mostly about speed and efficiency, however it achieves itsgoal by sometimes sacrificing the compression ratio which then affects
Xamarin.Android, the main LibZipSharp consumer.
Add a new
zlibsubmodule and switch to usingzlibby default insteadof
zlib-ng, while retainingzlib-ngas an option.