Bump libzip to 1.7.3 and go back to mingw #65
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
reviewed
Jul 17, 2020
azure-pipelines.yml
Outdated
| displayName: 'Test MacOS' | ||
| pool: | ||
| vmImage: macOS-10.14 | ||
| vmImage: xcode9-macos10.13 |
Contributor
There was a problem hiding this comment.
not sure we can use this machine anymore. we should use macOS-10.14
| solution: LibZipSharp.UnitTest/LibZipSharp.UnitTest.csproj | ||
| configuration: Release | ||
| msbuildArguments: /restore /t:RunNunitTests /p:ReferenceNuget=True /v:diag | ||
| - task: DotNetCoreCLI@2 |
Contributor
There was a problem hiding this comment.
We should keep this test so we can make sure we don't break net core.
grendello
force-pushed
the
libzip-1.7.3-mingw
branch
4 times, most recently
from
39c4693 to
37f9b2e
Compare
Context: https://libzip.org/news/release-1.7.3.html Context: https://libzip.org/news/release-1.7.2.html Context: https://libzip.org/news/release-1.7.1.html Context: https://libzip.org/news/release-1.7.0.html Upstream changes: * Add support for encrypting using traditional PKWare encryption. * Add zip_compression_method_supported(). * Add zip_encryption_method_supported(). * Add the ZIP_SOURCE_GET_FILE_ATTRIBUTES source command. * Refactor stdio file backend. * Add CMake find_project() support. * Restore LIBZIP_VERSION_{MAJOR,MINOR,MICRO} symbols. * Fixes warnings reported by PVS-Studio. * Add LIBZIP_DO_INSTALL build setting to make it easier to use libzip as subproject. * Fixes for the CMake find_project() files. * libzip moved to the CMake libzip:: NAMESPACE. * CMake usage best practice cleanups. * Support cmake < 3.17 again. * Fix pkgconfig file (regression in 1.7.2). Windows `libzip` DLL is again built with mingw
grendello
force-pushed
the
libzip-1.7.3-mingw
branch
from
37f9b2e to
c018021
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: https://libzip.org/news/release-1.7.3.html
Context: https://libzip.org/news/release-1.7.2.html
Context: https://libzip.org/news/release-1.7.1.html
Context: https://libzip.org/news/release-1.7.0.html
Upstream changes:
Windows
libzipDLL is again built with mingw