Weekly stable updates #415

github-actions · 2021-11-01T06:07:01Z

Update to latest stable versions of components:

Updated artifacts

androidx.activity:activity - 1.3.1 -> 1.4.0
- diff.md.txt
- breaking.md.txt
androidx.activity:activity-ktx - 1.3.1 -> 1.4.0
- no API changes
androidx.core:core - 1.6.0 -> 1.7.0
- diff.md.txt
- breaking.md.txt
androidx.core:core-ktx - 1.6.0 -> 1.7.0
- no API changes
androidx.lifecycle:lifecycle-common - 2.3.1 -> 2.4.0
- diff.md.txt
androidx.lifecycle:lifecycle-common-java8 - 2.3.1 -> 2.4.0
- no API changes
androidx.lifecycle:lifecycle-livedata - 2.3.1 -> 2.4.0
- no API changes
androidx.lifecycle:lifecycle-livedata-core - 2.3.1 -> 2.4.0
- no API changes
androidx.lifecycle:lifecycle-livedata-core-ktx - 2.3.1 -> 2.4.0
- no API changes
androidx.lifecycle:lifecycle-livedata-ktx - 2.3.1 -> 2.4.0
- no API changes
androidx.lifecycle:lifecycle-process - 2.3.1 -> 2.4.0
- diff.md.txt
- breaking.md.txt
androidx.lifecycle:lifecycle-reactivestreams - 2.3.1 -> 2.4.0
- no API changes
androidx.lifecycle:lifecycle-reactivestreams-ktx - 2.3.1 -> 2.4.0
- no API changes
androidx.lifecycle:lifecycle-runtime - 2.3.1 -> 2.4.0
- no API changes
androidx.lifecycle:lifecycle-runtime-ktx - 2.3.1 -> 2.4.0
- diff.md.txt
androidx.lifecycle:lifecycle-service - 2.3.1 -> 2.4.0
- no API changes
androidx.lifecycle:lifecycle-viewmodel - 2.3.1 -> 2.4.0
- diff.md.txt
- breaking.md.txt
androidx.lifecycle:lifecycle-viewmodel-ktx - 2.3.1 -> 2.4.0
- diff.md.txt
- breaking.md.txt
androidx.lifecycle:lifecycle-viewmodel-savedstate - 2.3.1 -> 2.4.0
- diff.md.txt
androidx.wear:wear-input - 1.0.0 -> 1.1.0
- no API changes
androidx.wear:wear-ongoing - 1.1.0 -> 1.0.0
- no API changes
androidx.window:window - 1.0.0-beta02 -> 1.0.0-beta04
- diff.md.txt
- breaking.md.txt
androidx.window:window-java - 1.0.0-beta02 -> 1.0.0-beta04
- diff.md.txt
- breaking.md.txt
com.google.code.gson:gson - 2.8.8 -> 2.8.9
- diff.md.txt
org.jetbrains.kotlinx:kotlinx-coroutines-guava - -> 1.5.2
com.google.firebase:firebase-appindexing - -> 20.0.0

Changed, but not updated

androidx.constraintlayout.constraintlayout
- Xamarin.AndroidX.ConstraintLayout
- diff.md.txt
androidx.coordinatorlayout.coordinatorlayout
- Xamarin.AndroidX.CoordinatorLayout
- diff.md.txt
androidx.security.security-crypto
- Xamarin.AndroidX.Security.SecurityCrypto
- diff.md.txt
- breaking.md.txt
androidx.swiperefreshlayout.swiperefreshlayout
- Xamarin.AndroidX.SwipeRefreshLayout
- diff.md.txt
androidx.wear.wear
- Xamarin.AndroidX.Wear
- diff.md.txt
com.google.crypto.tink.tink-android
- Xamarin.Google.Crypto.Tink.Android
- diff.md.txt
- breaking.md.txt

Checklist

Add any metadata needed to get PR to compile
Verify any new namespaces are properly renamed (utilities.cake)
Verify nuget/namespace spelling (utilities.cake)
Locally generate diffs
Review any breaking changes
Attach diffs to PR

jpobst

What is causing the need to rework these methods:

Removed methods:

public virtual void OnNestedScrollAccepted (Android.Views.View child, Android.Views.View target, Android.Views.ScrollAxis axes, int type);
public virtual bool OnStartNestedScroll (Android.Views.View child, Android.Views.View target, Android.Views.ScrollAxis axes, int type);

Added methods:

public virtual void OnNestedScrollAccepted (Android.Views.View child, Android.Views.View target, int axes);
public virtual void OnNestedScrollAccepted2 (Android.Views.View child, Android.Views.View target, int axes, int type);
public virtual bool OnStartNestedScroll (Android.Views.View child, Android.Views.View target, int axes);
public virtual bool OnStartNestedScroll2 (Android.Views.View child, Android.Views.View target, int axes, int type);

This seems to hit several packages. If these are widely used, this has the possibility to cause extensive breaks to the ecosystem. Is there a way we can do this in a backwards compatible way?

jpobst · 2021-11-04T14:37:10Z

mappings/dependencies.json

This file looks like it was replaced with config.json, is that intentional?

no.
I need to see what I have done

I resolved conflicts manually in github editor. Seems like I pasted config.json somehow. Not sure.

building fromscratch to regenerate dependencies.json

jpobst · 2021-11-04T14:49:42Z

It looks like something changed to the parameter names in AndroidX.Core, which is causing the enumification changes to fail:

/Users/runner/work/1/s/generated/androidx.core.core/obj/Release/monoandroid9.0/generated/metadata(8,4): warning BG8A04: Metadata.xml element '<attr path="/api/package[@name='androidx.core.view']/*[@name='NestedScrollingParent']/method[@name='onStartNestedScroll']/parameter[@name='axis']" />' matched no nodes. [/Users/runner/work/1/s/generated/androidx.core.core/androidx.core.core.csproj]

However we should still be changing the parameter name with this in Metadata.ParameterNames.xml:

<attr path="/api/package[@name='androidx.core.view']/interface[@name='NestedScrollingParent']/method[@name='onStartNestedScroll' and count(parameter)=3 and parameter[1][@type='android.view.View'] and parameter[2][@type='android.view.View'] and parameter[3][@type='int']]/parameter[3]" name="managedName">axes</attr>

This does not happen on main, so I think we need to investigate what is causing this to see if we can get it working again.

moljac · 2021-11-04T16:54:43Z

What is causing the need to rework these methods:

Removed methods:

public virtual void OnNestedScrollAccepted (Android.Views.View child, Android.Views.View target, Android.Views.ScrollAxis axes, int type);
public virtual bool OnStartNestedScroll (Android.Views.View child, Android.Views.View target, Android.Views.ScrollAxis axes, int type);

Added methods:

public virtual void OnNestedScrollAccepted (Android.Views.View child, Android.Views.View target, int axes);
public virtual void OnNestedScrollAccepted2 (Android.Views.View child, Android.Views.View target, int axes, int type);
public virtual bool OnStartNestedScroll (Android.Views.View child, Android.Views.View target, int axes);
public virtual bool OnStartNestedScroll2 (Android.Views.View child, Android.Views.View target, int axes, int type);

This seems to hit several packages. If these are widely used, this has the possibility to cause extensive breaks to the ecosystem. Is there a way we can do this in a backwards compatible way?

Not sure. I noticed some changes in interfaces in AndroidX.Core.View during last WSU (week ago):

AndroidX.Core.View.INestedScrollingParent
AndroidX.Core.View.INestedScrollingParent2
AndroidX.Core.View.INestedScrollingParent3

https://developer.android.com/reference/androidx/core/view/NestedScrollingParent

https://developer.android.com/reference/androidx/core/view/NestedScrollingParent2

https://developer.android.com/reference/androidx/core/view/NestedScrollingParent3

It is interfaces that inherit one from another and I was not sure if that was google's breaking change or C# limitations or binding tooling issue.

The culprit are changes in AndroidX.Core and i simply could not solve some build errors, but this way. I might overlooked something. I will try to redo those changes. Maybe some time off will help me or if you could take a look...

I will try to fix thoses over the weekend

jpobst · 2021-11-04T21:16:13Z

The issue appears to be that core-1.6.0.aar is compiled to contain parameter names, however core-1.7.0.aar is not. We do enumification for a few places like for axes in NestedScrollingParent.onNestedScrollAccepted (...):

https://github.com/xamarin/AndroidX/blob/main/source/androidx.core/core/Transforms/EnumMethods.xml#L47-L50

Because these are based off parameter names which no longer exist, they no longer match and are no longer being applied.

The good news is we have already have a Metadata.ParameterNames.xml that can fix the parameter names, and it runs before enumification.

The issue is that these transforms modify the parameter managedName instead of name, which is what the enumification process is looking for. Although managedName is generally what should be used, in this case we can abuse it and use name instead. This will both rename the parameter in the bindings as well as change the api.xml so that subsequent fixups looking for name will work.

Replacing every "managedName" with "name" in Metadata.ParameterNames.xml will allow things to continue working the same as before, avoiding any compatibility breaking.

moljac · 2021-11-09T11:05:00Z

attempt to fix parameters with corrected paths for JavaSourceJar and JavaDocJar

  <ItemGroup>
    @foreach (var art in @Model.MavenArtifacts)
    {
    <JavaSourceJar
          Include="..\..\externals\@(art.MavenGroupId)\@(art.MavenArtifactId)-sources.jar"
          Condition="Exists('..\..\externals\@(art.MavenGroupId)\@(art.MavenArtifactId)-sources.jar')"
          />
    <JavaDocJar
          Include="..\..\externals\@(art.MavenGroupId)\@(art.MavenArtifactId)-javadoc.jar"
          Condition="Exists('..\..\externals\@(art.MavenGroupId)\@(art.MavenArtifactId)-javadoc.jar')"
          />
    }
  </ItemGroup>

fails with following error:

/Library/Frameworks/Xamarin.Android.framework/Libraries/xbuild/Xamarin/Android/Xamarin.Android.Bindings.ClassParse.targets(30,5): error XACLP7004: System.ArgumentException: Directory '//Users/Shared/Projects/d/X/AX/wsu-20211101/generated/androidx.databinding.databinding-common/obj/Release/monoandroid9.0/javadocs/databinding-common-javadoc/' does not appear to be an android doc reference directory. [/Users/Shared/Projects/d/X/AX/wsu-20211101/generated/androidx.databinding.databinding-common/androidx.databinding.databinding-common.csproj]
/Library/Frameworks/Xamarin.Android.framework/Libraries/xbuild/Xamarin/Android/Xamarin.Android.Bindings.ClassParse.targets(30,5): error XACLP7004:    at Xamarin.Android.Tools.Bytecode.AndroidDocScraper..ctor(String dir, String patternHead, String resetPatternHead, String parameterPairSplitter, Boolean continuousParamLines, String openMethod, String paramSep, String closeMethod, String postCloseMethodParens) in /Users/builder/azdo/_work/1/s/xamarin-android/external/Java.Interop/src/Xamarin.Android.Tools.Bytecode/JavaDocumentScraper.cs:line 168 [/Users/Shared/Projects/d/X/AX/wsu-20211101/generated/androidx.databinding.databinding-common/androidx.databinding.databinding-common.csproj]
/Library/Frameworks/Xamarin.Android.framework/Libraries/xbuild/Xamarin/Android/Xamarin.Android.Bindings.ClassParse.targets(30,5): error XACLP7004:    at Xamarin.Android.Tools.Bytecode.AndroidDocScraper..ctor(String dir, String patternHead, String resetPatternHead, String parameterPairSplitter, Boolean continuousParamLines) in /Users/builder/azdo/_work/1/s/xamarin-android/external/Java.Interop/src/Xamarin.Android.Tools.Bytecode/JavaDocumentScraper.cs:line 145 [/Users/Shared/Projects/d/X/AX/wsu-20211101/generated/androidx.databinding.databinding-common/androidx.databinding.databinding-common.csproj]
/Library/Frameworks/Xamarin.Android.framework/Libraries/xbuild/Xamarin/Android/Xamarin.Android.Bindings.ClassParse.targets(30,5): error XACLP7004:    at Xamarin.Android.Tools.Bytecode.DroidDocScraper..ctor(String dir) in /Users/builder/azdo/_work/1/s/xamarin-android/external/Java.Interop/src/Xamarin.Android.Tools.Bytecode/JavaDocumentScraper.cs:line 41 [/Users/Shared/Projects/d/X/AX/wsu-20211101/generated/androidx.databinding.databinding-common/androidx.databinding.databinding-common.csproj]
/Library/Frameworks/Xamarin.Android.framework/Libraries/xbuild/Xamarin/Android/Xamarin.Android.Bindings.ClassParse.targets(30,5): error XACLP7004:    at Xamarin.Android.Tools.Bytecode.ClassPath.CreateDocScraper(String src) in /Users/builder/azdo/_work/1/s/xamarin-android/external/Java.Interop/src/Xamarin.Android.Tools.Bytecode/ClassPath.cs:line 249 [/Users/Shared/Projects/d/X/AX/wsu-20211101/generated/androidx.databinding.databinding-common/androidx.databinding.databinding-common.csproj]
/Library/Frameworks/Xamarin.Android.framework/Libraries/xbuild/Xamarin/Android/Xamarin.Android.Bindings.ClassParse.targets(30,5): error XACLP7004:    at Xamarin.Android.Tools.Bytecode.ClassPath.FixupParametersFromDocs(XElement api, String path) in /Users/builder/azdo/_work/1/s/xamarin-android/external/Java.Interop/src/Xamarin.Android.Tools.Bytecode/ClassPath.cs:line 260 [/Users/Shared/Projects/d/X/AX/wsu-20211101/generated/androidx.databinding.databinding-common/androidx.databinding.databinding-common.csproj]
/Library/Frameworks/Xamarin.Android.framework/Libraries/xbuild/Xamarin/Android/Xamarin.Android.Bindings.ClassParse.targets(30,5): error XACLP7004:    at Xamarin.Android.Tools.Bytecode.ClassPath.FixupParametersFromDocs(XElement api) in /Users/builder/azdo/_work/1/s/xamarin-android/external/Java.Interop/src/Xamarin.Android.Tools.Bytecode/ClassPath.cs:line 241 [/Users/Shared/Projects/d/X/AX/wsu-20211101/generated/androidx.databinding.databinding-common/androidx.databinding.databinding-common.csproj]
/Library/Frameworks/Xamarin.Android.framework/Libraries/xbuild/Xamarin/Android/Xamarin.Android.Bindings.ClassParse.targets(30,5): error XACLP7004:    at Xamarin.Android.Tools.Bytecode.ClassPath.ToXElement() in /Users/builder/azdo/_work/1/s/xamarin-android/external/Java.Interop/src/Xamarin.Android.Tools.Bytecode/ClassPath.cs:line 314 [/Users/Shared/Projects/d/X/AX/wsu-20211101/generated/androidx.databinding.databinding-common/androidx.databinding.databinding-common.csproj]
/Library/Frameworks/Xamarin.Android.framework/Libraries/xbuild/Xamarin/Android/Xamarin.Android.Bindings.ClassParse.targets(30,5): error XACLP7004:    at Xamarin.Android.Tools.Bytecode.ClassPath.SaveXmlDescription(TextWriter textWriter) in /Users/builder/azdo/_work/1/s/xamarin-android/external/Java.Interop/src/Xamarin.Android.Tools.Bytecode/ClassPath.cs:line 333 [/Users/Shared/Projects/d/X/AX/wsu-20211101/generated/androidx.databinding.databinding-common/androidx.databinding.databinding-common.csproj]
/Library/Frameworks/Xamarin.Android.framework/Libraries/xbuild/Xamarin/Android/Xamarin.Android.Bindings.ClassParse.targets(30,5): error XACLP7004:    at Xamarin.Android.Tasks.ClassParse.RunTask() [/Users/Shared/Projects/d/X/AX/wsu-20211101/generated/androidx.databinding.databinding-common/androidx.databinding.databinding-common.csproj]
/Library/Frameworks/Xamarin.Android.framework/Libraries/xbuild/Xamarin/Android/Xamarin.Android.Bindings.ClassParse.targets(30,5): error XACLP7004:    at Microsoft.Android.Build.Tasks.AndroidTask.Execute() in /Users/builder/azdo/_work/1/s/xamarin-android/external/xamarin-android-tools/src/Microsoft.Android.Build.BaseTasks/AndroidTask.cs:line 17 [/Users/Shared/Projects/d/X/AX/wsu-20211101/generated/androidx.databinding.databinding-common/androidx.databinding.databinding-common.csproj]

Seems to be single project/artifact.

This reverts commit 4a84d0e.

jpobst

It looks like the ParameterNames.Metadata.xml for AndroidX.Core isn't very complete. There are still a lot of parameter names missing, resulting in actual API breaks like:

Type Changed: AndroidX.Core.View.WindowInsetsControllerCompat.ControllableInsetsChangedEventArgs

Removed properties:

public WindowInsetsControllerCompat Controller { get; }
public int TypeMask { get; }

Added properties:

public WindowInsetsControllerCompat P0 { get; }
public int P1 { get; }

Maybe we should try using the JavaSourceJar for only this library to see if it gets us back to where we were before.

I think once we get AndroidX.Core back to normal, we also won't need the Additions added for things like OnNestedScrollAccepted.

moljac · 2021-11-16T14:46:41Z

Maybe we should try using the JavaSourceJar for only this library to see if it gets us back to where we were before.

OK. Let me try that

## Depends on #415 - do not merge before that

jpobst · 2021-11-18T19:40:22Z

Maybe we should try using the JavaSourceJar for only this library to see if it gets us back to where we were before.

With JavaSourceJar:

From the diff, it does not look like JavaSourceJar got enabled. It appears that JavaDocJar got enabled instead and androidx.core does not provide a JavaDoc artifact. I would also suggest only turning it on for androidx.core unless other packages need it, as it is likely to cause other breaking changes.

Properties:

public WindowInsetsControllerCompat Controller { get; }
public int TypeMask { get; }

seem to be removed:

This is because they are properties automatically generated for EventArgs from the listener method parameters:

public interface OnControllableInsetsChangedListener
{
    void onControllableInsetsChanged(@NonNull final WindowInsetsControllerCompat p0, final int p1);
}

Without the parameter names, these properties get renamed:

Type Changed: AndroidX.Core.View.WindowInsetsControllerCompat.ControllableInsetsChangedEventArgs

Removed properties:

public WindowInsetsControllerCompat Controller { get; }
public int TypeMask { get; }

Added properties:

public WindowInsetsControllerCompat P0 { get; }
public int P1 { get; }

moljac · 2021-11-22T13:11:52Z

JavaSourceJar is turned on only for androidx.core, but api-diff looks almost the same:

https://github.com/xamarin/AndroidX/blob/create-pull-request/patch-1635746820/source/AndroidXProject.cshtml#L74-L91

moljac · 2021-11-22T13:13:18Z

so many changes on CI in last 2 weeks. Seems like macosx-latest does not work for XCode 13.1.

Fixing that

moljac · 2021-11-29T10:53:21Z

Seems that methods were moved to other interfaces and there is no other removed stuff in Core api-diff!!

Namespace AndroidX.Core.View

Type Changed: AndroidX.Core.View.INestedScrollingParent

Removed methods:

public virtual void OnNestedScrollAccepted (Android.Views.View child, Android.Views.View target, Android.Views.ScrollAxis axes);
public virtual bool OnStartNestedScroll (Android.Views.View child, Android.Views.View target, Android.Views.ScrollAxis axes);

Type Changed: AndroidX.Core.View.INestedScrollingParent2

Modified methods:

-public abstract void OnNestedScrollAccepted (Android.Views.View child, Android.Views.View target, Android.Views.ScrollAxis axes, int type)
+public abstract void OnNestedScrollAccepted (Android.Views.View child, Android.Views.View target, Android.Views.ScrollAxis axes, int _type)
-public abstract bool OnStartNestedScroll (Android.Views.View child, Android.Views.View target, Android.Views.ScrollAxis axes, int type)
+public abstract bool OnStartNestedScroll (Android.Views.View child, Android.Views.View target, Android.Views.ScrollAxis axes, int _type)

Type Changed: AndroidX.Core.View.INestedScrollingParent3

Modified methods:

-public abstract void OnNestedScroll (Android.Views.View target, int dxConsumed---p1---, int dyConsumed---p2---, int dxUnconsumed---p3---, int dyUnconsumed---p4---, int type---p5---, int[] consumed---p6---)
+public abstract void OnNestedScroll (Android.Views.View p0, int +++dxConsumed+++p1, int +++dyConsumed+++p2, int +++dxUnconsumed+++p3, int +++dyUnconsumed+++p4, int +++type+++p5, int[] +++consumed+++p6)

This reverts commit 7ba5d15.

Use metadata from 1.6.0 to restore parameter names for AndroidX.Core.

moljac · 2021-12-01T21:26:03Z

merging and will bump for tomorrow

conceptdev · 2021-12-02T23:47:57Z

@moljac @jpobst the Xamarin.AndroidX.Window.WindowJava beta04 from this PR results in a build error:

10>C:\GitHubMicrosoft\surface-duo-sdk-xamarin-samples\WindowManager\obj\Debug\110\lp\54\jl\res\values\values.xml(114): error APT2260: resource android:attr/lStar not found.
10>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\Android\Xamarin.Android.Aapt2.targets(157,3): error APT2062: failed linking references.

The 1.0.0.3-beta03 build from #418 works fine (although we never merged this to main).

Googling turned up this StackOverflow post which suggests the issue is related to a version of Xamarin.AndroidX.Core (1.6 vs 1.7 possibly) but I can't be sure this is the problem. Any thoughts?

moljac · 2021-12-03T09:55:11Z

@moljac @jpobst the Xamarin.AndroidX.Window.WindowJava beta04 from this PR results in a build error:

10>C:\GitHubMicrosoft\surface-duo-sdk-xamarin-samples\WindowManager\obj\Debug\110\lp\54\jl\res\values\values.xml(114): error APT2260: resource android:attr/lStar not found.
10>C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\MSBuild\Xamarin\Android\Xamarin.Android.Aapt2.targets(157,3): error APT2062: failed linking references.

I have never seen this.

The 1.0.0.3-beta03 build from #418 works fine (although we never merged this to main).

Googling turned up this StackOverflow post which suggests the issue is related to a version of Xamarin.AndroidX.Core (1.6 vs 1.7 possibly) but I can't be sure this is the problem. Any thoughts?

We had issues with Xamarin.AndroidX.Core 1.7., but I doubt this is related.

Googling a bit

https://exerror.com/solved-aapt-error-resource-androidattr-lstar-not-found-in-android/

https://www.nuget.org/packages/Xamarin.AndroidX.Core.Core.Ktx/1.7.0.1

https://www.nuget.org/packages/Xamarin.AndroidX.Core.Core.Ktx/1.6.0.3

If you are using androidx.core:core-ktx:+ then this will find the latest version of androidx.core:core-ktx:+ and the latest one is 1.7.0 and the latest version needs the Android 31 compile SDK. So that You are facing this issue. Here is Two Possible Solution use a specific version, use androidx.core:core-ktx:${version} instead of androidx.core:core-ktx:+ upgrade the compile SDK to Android 31

conceptdev · 2021-12-03T18:05:23Z

🤦‍♂️ thanks @moljac - first time I've hit an API requiring API 31... I should have thought to try that before bothering you.

The beta04 binding seems to work now (I've tested with one sample) - will update the rest but I don't anticipate any other problems.

Thank you!

moljac · 2021-12-03T20:09:42Z

🤦‍♂️ thanks @moljac - first time I've hit an API requiring API 31... I should have thought to try that before bothering you.

You did not bother. Too bad I don't have time to use all those packages.

The beta04 binding seems to work now (I've tested with one sample) - will update the rest but I don't anticipate any other problems.

Great news. Glad to hear that!

Thank you!

You are welcome. I hope next time I'll be faster with update[s].

conceptdev · 2021-12-03T20:59:28Z

Final comment - confirmed that the Surface Duo samples were updated and work fine

microsoft/surface-duo-sdk-xamarin-samples#32

Weekly stable updates

69be9e8

github-actions bot assigned moljac Nov 1, 2021

moljac added 8 commits November 2, 2021 17:04

window beta03 bumps

1e07c81

metadata fixes

4a84d0e

mappings

10ac50d

tests fixes and nuget updates

817890d

BuildAll sample updates

59f4bb9

fix for aapt2 error with AndroidX.Core 1.7.0 (explicit version 1.6.0)

8d845d3

namespaces fixes in metadata

81b8540

Merge branch 'main' into create-pull-request/patch-1635746820

c384bb8

moljac mentioned this pull request Nov 3, 2021

Update AndroidX.Window and WindowJava to beta03 #418

Closed

moljac requested a review from jpobst November 3, 2021 18:08

moljac marked this pull request as ready for review November 3, 2021 18:08

jpobst reviewed Nov 4, 2021

View reviewed changes

regenerated dependencies.json

616f255

moljac added 6 commits November 9, 2021 15:02

JavaSourceJar and JavaDocJar path fix

d803fe6

turned off parameter tools JavaSourceJar and JavaDocJar

178be2f

comment for future formatting

e9ead07

Revert "metadata fixes"

d5b18cd

This reverts commit 4a84d0e.

metadata fixes

7ba5d15

Update dependencies.json

09ed59c

moljac requested a review from jpobst November 15, 2021 10:24

jpobst reviewed Nov 15, 2021

View reviewed changes

JavaDocJar parameter generation turned on

89fe734

conceptdev mentioned this pull request Nov 18, 2021

Update "AndroidX.Window" to "1.0.0-beta04" #428

Closed

conceptdev added a commit that referenced this pull request Nov 18, 2021

Update AndroidX.Window and WindowJava to beta04

617dc4d

## Depends on #415 - do not merge before that

conceptdev mentioned this pull request Nov 18, 2021

Update AndroidX.Window and WindowJava to beta04 #429

Closed

moljac added 6 commits November 19, 2021 00:16

turn on JavaSourceJar only for Xamarin.AndroidX.Core

eb4c3de

Update dependencies.json

92ac7c9

XCode, Binderator, dotnet version bumps

2bb3e99

bump Xamarin.AndroidX.Window version

754da11

more androidx.window version bumps

b38f3c7

Update dependencies.json

a90f34d

moljac added 3 commits November 22, 2021 14:15

macosImage: 'macOS-11'

4f0dcd2

dotnet versions specified

a2248ca

dotnet 5.0.403 for binderator

cde54fa

moljac requested a review from jpobst November 29, 2021 10:54

jpobst and others added 3 commits November 30, 2021 10:20

Revert "metadata fixes"

c80e36e

This reverts commit 7ba5d15.

Use metadata from 1.6.0 to restore parameter names for AndroidX.Core.

e536263

Merge pull request #432 from xamarin/core-parameternames

08a6f89

Use metadata from 1.6.0 to restore parameter names for AndroidX.Core.

jpobst approved these changes Dec 1, 2021

View reviewed changes

moljac merged commit 4e40914 into main Dec 1, 2021

moljac deleted the create-pull-request/patch-1635746820 branch December 1, 2021 21:26

conceptdev mentioned this pull request Dec 3, 2021

[all] update Jetpack Window Manager (beta04) microsoft/surface-duo-sdk-xamarin-samples#32

Merged

Weekly stable updates #415

Weekly stable updates #415

Uh oh!

Conversation

github-actions bot commented Nov 1, 2021 • edited by moljac Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Updated artifacts

Changed, but not updated

Uh oh!

jpobst left a comment

Choose a reason for hiding this comment

Uh oh!

jpobst Nov 4, 2021

Choose a reason for hiding this comment

Uh oh!

moljac Nov 4, 2021

Choose a reason for hiding this comment

Uh oh!

moljac Nov 4, 2021

Choose a reason for hiding this comment

Uh oh!

moljac Nov 4, 2021

Choose a reason for hiding this comment

Uh oh!

moljac Nov 4, 2021

Choose a reason for hiding this comment

Uh oh!

jpobst commented Nov 4, 2021

Uh oh!

moljac commented Nov 4, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jpobst commented Nov 4, 2021

Uh oh!

moljac commented Nov 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jpobst left a comment

Choose a reason for hiding this comment

Type Changed: AndroidX.Core.View.WindowInsetsControllerCompat.ControllableInsetsChangedEventArgs

Uh oh!

moljac commented Nov 16, 2021

Uh oh!

jpobst commented Nov 18, 2021

Type Changed: AndroidX.Core.View.WindowInsetsControllerCompat.ControllableInsetsChangedEventArgs

Uh oh!

moljac commented Nov 22, 2021

Uh oh!

moljac commented Nov 22, 2021

Uh oh!

moljac commented Nov 29, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Namespace AndroidX.Core.View

Type Changed: AndroidX.Core.View.INestedScrollingParent

Type Changed: AndroidX.Core.View.INestedScrollingParent2

Type Changed: AndroidX.Core.View.INestedScrollingParent3

Uh oh!

moljac commented Dec 1, 2021

Uh oh!

conceptdev commented Dec 2, 2021

Uh oh!

moljac commented Dec 3, 2021

Uh oh!

conceptdev commented Dec 3, 2021

Uh oh!

moljac commented Dec 3, 2021

Uh oh!

conceptdev commented Dec 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Nov 1, 2021 •

edited by moljac

Loading

moljac commented Nov 4, 2021 •

edited

Loading

moljac commented Nov 9, 2021 •

edited

Loading

moljac commented Nov 29, 2021 •

edited

Loading

conceptdev commented Dec 3, 2021 •

edited

Loading