-
Notifications
You must be signed in to change notification settings - Fork 64
Template sets Guava #395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Template sets Guava #395
Conversation
|
Guava has non-standard naming EDIT: it is not naming, but version. It is stable, but for SemVer it is preview. https://mvnrepository.com/artifact/com.google.guava/guava https://repo1.maven.org/maven2/com/google/guava/guava/30.0-android/ |
|
Problem to solve: |
|
Following data: causes Maven.Net error while |
|
/azp run |
|
Pull request contains merge conflicts. |
|
Guava ( depends on There are 2 versions of
Working solution 1 - template setThis works but a lot of Working solution 2 - dependenciesThis works too for binderator and build step (old config when guava was in XC repo): but fails with samples: |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Analysis after commit Tricks for
cleaned up: |
|
New updates in AndroidX need guava JRE!!! |
|
Parts of this were used and committed with #531. |
Describe your contribution
Moving Guava dependencies from XamarinComponents to AndroidX repo as templete set.
com.google.guava:guava- 29.0.0 -> 29.0-androidcom.google.guava:listenablefuture- 1.0 -> 9999.0-empty-to-avoid-conflict-with-guavacom.google.guava:failureaccess- -> 1.0.1Updated/new (moved) artifacts
Does this change any of the generated binding API's?
net6-androidTFM addedArtifacts updated
changed
Xamarin.Google.J2Objc.J2ObjcAnnotations
com.google.j2objc.j2objc-annotations
Xamarin.AndroidX.Media2.Common
androidx.media2.media2-common
Xamarin.AndroidX.Window.WindowJava
androidx.window.window-java
Xamarin.KotlinX.Coroutines.Guava
org.jetbrains.kotlinx.kotlinx-coroutines-guava
Xamarin.AndroidX.Security.SecurityCrypto
androidx.security.security-crypto
Xamarin.AndroidX.Lifecycle.Common
androidx.lifecycle.lifecycle-common
Xamarin.AndroidX.Media2.Session
androidx.media2.media2-session
Xamarin.AndroidX.Lifecycle.Process
androidx.lifecycle.lifecycle-process
Xamarin.AndroidX.Lifecycle.ViewModelSavedState
androidx.lifecycle.lifecycle-viewmodel-savedstate
Xamarin.AndroidX.Lifecycle.ViewModel.Ktx
androidx.lifecycle.lifecycle-viewmodel-ktx
Xamarin.AndroidX.Work.Runtime
androidx.work.work-runtime
Xamarin.AndroidX.Room.Guava
androidx.room.room-guava
Xamarin.Google.Code.FindBugs
com.google.code.findbugs.jsr305
Xamarin.Google.ErrorProne.ErrorProneAnnotations
com.google.errorprone.error_prone_annotations
Xamarin.AndroidX.Camera.Lifecycle
androidx.camera.camera-lifecycle
Xamarin.AndroidX.Camera.Camera2
androidx.camera.camera-camera2
Xamarin.AndroidX.Window
androidx.window.window
Xamarin.AndroidX.Concurrent.Futures
androidx.concurrent.concurrent-futures
Xamarin.AndroidX.Lifecycle.ViewModel
androidx.lifecycle.lifecycle-viewmodel
Xamarin.CheckerFramework.CheckerCompatQual
org.checkerframework.checker-compat-qual
Xamarin.AndroidX.MediaRouter
androidx.mediarouter.mediarouter
Xamarin.AndroidX.Ads.Identifier
androidx.ads.ads-identifier
Xamarin.AndroidX.Lifecycle.Runtime.Ktx
androidx.lifecycle.lifecycle-runtime-ktx
Xamarin.AndroidX.Wear.RemoteInteractions
androidx.wear.wear-remote-interactions
Xamarin.AndroidX.Activity
androidx.activity.activity
GoogleGson
com.google.code.gson.gson
Xamarin.Google.Guava.ListenableFuture
com.google.guava.listenablefuture
Xamarin.AndroidX.Core
androidx.core.core
Xamarin.AndroidX.Camera.Core
androidx.camera.camera-core
Xamarin.AndroidX.Work.Work.Runtime.Ktx
androidx.work.work-runtime-ktx
Xamarin.Google.Crypto.Tink.Android
com.google.crypto.tink.tink-android
Xamarin.AndroidX.Browser
androidx.browser.browser
Checklist