Merge to Shared for DbConnectionPoolGroup #1371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdate references in the csproj and reorder the DbConnectionPool entries to be alphabetical
|
Hopefully #862 can get merged first... |
|
There's no rush for this PR at the moment, I realized I had this change on a local branch, but held off on the PR because there was the 4.0.0-preview3 release, so I didn't want to take up too much azure devops pipeline resources, so your changes can go first. |
cheenamalhotra
added
the
Code Health 💊
johnnypham
approved these changes
Jan 17, 2022
DavoudEshtehari
requested review from
JRahnama,
Kaur-Parminder and
DavoudEshtehari
Kaur-Parminder
approved these changes
Apr 6, 2022
DavoudEshtehari
approved these changes
Apr 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #1261 . Merged netfx into netcore for DbConnectionPoolGroup, and moving it to shared src and updating file to conform with coding style.