Skip to content

Share Member Identifiers #1048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Share Member Identifiers #1048

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9b06610
Share Member Identifiers
HurricanKai Aug 19, 2022
e303d13
Allow low coverage
HurricanKai Aug 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ jobs:
hide_complexity: true
indicators: true
output: file
thresholds: '60 80'
thresholds: '30 70'
- name: Add Coverage PR Comment
uses: marocchino/sticky-pull-request-comment@v2
if: always() && github.event_name == 'pull_request'
Expand Down
2 changes: 1 addition & 1 deletion src/generators/Silk.NET.SilkTouch.Symbols/FieldSymbol.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,4 +9,4 @@ namespace Silk.NET.SilkTouch.Symbols;
/// <param name="Type">The <see cref="TypeReference"/> of the data stored in this field</param>
/// <param name="Identifier">The Identifier of this field</param>
/// <seealso cref="MemberSymbol"/>
public sealed record FieldSymbol(TypeReference Type, IdentifierSymbol Identifier) : MemberSymbol;
public sealed record FieldSymbol(TypeReference Type, IdentifierSymbol Identifier) : MemberSymbol(Identifier);
2 changes: 1 addition & 1 deletion src/generators/Silk.NET.SilkTouch.Symbols/MemberSymbol.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,4 +7,4 @@ namespace Silk.NET.SilkTouch.Symbols;
/// A <see cref="MemberSymbol"/>, representing a generic member of some <see cref="TypeSymbol"/>
/// </summary>
/// <seealso cref="FieldSymbol"/>
public abstract record MemberSymbol : Symbol;
public abstract record MemberSymbol(IdentifierSymbol Identifier) : Symbol;
4 changes: 3 additions & 1 deletion src/generators/Silk.NET.SilkTouch.Symbols/MethodSymbol.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,9 @@ namespace Silk.NET.SilkTouch.Symbols;
/// <summary>
/// A <see cref="MemberSymbol"/> representing a method with a signature.
/// </summary>
public abstract record MethodSymbol(TypeReference ReturnType, ImmutableArray<Parameter> Parameters, IdentifierSymbol Identifier) : MemberSymbol;
public abstract record MethodSymbol
(TypeReference ReturnType, ImmutableArray<Parameter> Parameters, IdentifierSymbol Identifier)
: MemberSymbol(Identifier);

/// <summary>
/// Represents a Parameter to a <see cref="MethodSymbol"/>
Expand Down