Update to 2.2.1-servicing #928
Conversation
| <MicrosoftAspNetCoreServerKestrelPackageVersion>2.2.0-preview3-35425</MicrosoftAspNetCoreServerKestrelPackageVersion> | ||
| <MicrosoftAspNetCoreStaticFilesPackageVersion>2.2.0-preview3-35425</MicrosoftAspNetCoreStaticFilesPackageVersion> | ||
| <MicrosoftAspNetCoreTestingPackageVersion>2.2.0-preview3-35425</MicrosoftAspNetCoreTestingPackageVersion> | ||
| <MicrosoftApplicationInsightsAspNetCorePackageVersion>2.2.0</MicrosoftApplicationInsightsAspNetCorePackageVersion> |
There was a problem hiding this comment.
Are all dependencies still 2.2.0?
There was a problem hiding this comment.
@natemcmaster - per your email I updated all these to 2.2.0, just want to confirm that that's correct.
There was a problem hiding this comment.
This particular one should be kept at 2.1.1. AppInsights is a partner's team package. You may not want to update your dependency from 2.1.1 to 2.2.0 in a patch update.
natemcmaster
left a comment
natemcmaster
left a comment
There was a problem hiding this comment.
This is close. Just a few things I would recommend changing. otherwise looks good.
| <VersionSuffix>rtm</VersionSuffix> | ||
| <VersionPrefix>2.2.1</VersionPrefix> | ||
| <VersionSuffix>servicing</VersionSuffix> | ||
| <PackageVersion Condition="'$(IsFinalBuild)' == 'true' AND '$(VersionSuffix)' == 'rtm' ">$(VersionPrefix)</PackageVersion> |
There was a problem hiding this comment.
You'll also need to update this line, otherwise the final package builds wont be "2.2.1". I recommend replacing your version.props file with this: https://github.com/aspnet/EntityFrameworkCore/blob/release/2.2/version.props
| <MicrosoftAspNetCoreServerKestrelPackageVersion>2.2.0-preview3-35425</MicrosoftAspNetCoreServerKestrelPackageVersion> | ||
| <MicrosoftAspNetCoreStaticFilesPackageVersion>2.2.0-preview3-35425</MicrosoftAspNetCoreStaticFilesPackageVersion> | ||
| <MicrosoftAspNetCoreTestingPackageVersion>2.2.0-preview3-35425</MicrosoftAspNetCoreTestingPackageVersion> | ||
| <MicrosoftApplicationInsightsAspNetCorePackageVersion>2.2.0</MicrosoftApplicationInsightsAspNetCorePackageVersion> |
There was a problem hiding this comment.
This particular one should be kept at 2.1.1. AppInsights is a partner's team package. You may not want to update your dependency from 2.1.1 to 2.2.0 in a patch update.
Update the scaffolding build to 2.2.1-servicing-