-
-
Notifications
You must be signed in to change notification settings - Fork 1k
feat: Add JobOrderPolicy option to sort jobs by numeric order #2770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
timcassell
merged 1 commit into
dotnet:master
from
filzrev:feat-add-options-sort-jobs-numericorder
Jun 13, 2025
Merged
feat: Add JobOrderPolicy option to sort jobs by numeric order #2770
timcassell
merged 1 commit into
dotnet:master
from
filzrev:feat-add-options-sort-jobs-numericorder
Jun 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
58bc8cd
to
a93bf0e
Compare
a93bf0e
to
fb0373b
Compare
timcassell
approved these changes
Jun 13, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @filzrev!
This was referenced Jul 21, 2025
This was referenced Sep 4, 2025
Open
This was referenced Sep 11, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intended to fix issue #2768.
What's changed in this PR
JobOrderPolicy
that similar toSummaryOrderPolicy
/MethodOrderPolicy
DefaultOrderer
/JobComparer
/OrdererAttribute
to acceptJobOrderPolicy
parameter.NumericStringComparer
nested class toJobComparer
. this class compare string with numeric ordering.JobOrderTests.cs
Note: This PR don't change existing behaviors.
Numeric job ordering
feature is enabled when explicitly enabled.List of Job characteristics
Job characteristics is compared by following priorities.
BenchmarkDotNet/src/BenchmarkDotNet/Jobs/JobComparer.cs
Lines 27 to 47 in c84de9a