Skip to content

Test for both .sln and .slnx when searching for solution file #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2025
Merged

Test for both .sln and .slnx when searching for solution file #2764

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/BenchmarkDotNet/Toolchains/DotNetCli/DotNetCliGenerator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,8 @@ public abstract class DotNetCliGenerator : GeneratorBase
{
private static readonly string[] ProjectExtensions = { ".csproj", ".fsproj", ".vbroj" };

private static readonly string[] SolutionExtensions = { ".sln", ".slnx" };

[PublicAPI] public string TargetFrameworkMoniker { get; }

[PublicAPI] public string CliPath { get; }
Expand Down Expand Up @@ -111,7 +113,7 @@ protected override void GenerateBuildScript(BuildPartition buildPartition, Artif
private static bool IsRootSolutionFolder(DirectoryInfo directoryInfo)
=> directoryInfo
.GetFileSystemInfos()
.Any(fileInfo => fileInfo.Extension == ".sln" || fileInfo.Name == "global.json");
.Any(fileInfo => SolutionExtensions.Contains(fileInfo.Extension) || fileInfo.Name == "global.json");

private static bool IsRootProjectFolder(DirectoryInfo directoryInfo)
=> directoryInfo
Expand Down