Skip to content

Conversation

alastairlundy
Copy link
Contributor

This PR fixes #2747 by adding the WmiLightCpuDetector detector class that detects CPU info using the WmiLight library.

This PR also updates WmicCpuDetector to also check for the presence of WMIC.exe at the expected file path to check for applicability so that it isn't used on systems without WMIC.exe .

The output is as expected when tested. For testing I used the BenchmarkDotNet Samples project.

// * Summary *

BenchmarkDotNet v0.15.1-develop (2025-06-04), Windows 11 (10.0.26100.4061/24H2/2024Update/HudsonValley)
12th Gen Intel Core i7-1270P 2.20GHz, 1 CPU, 16 logical and 12 physical cores
.NET SDK 9.0.300
  [Host]     : .NET 8.0.16 (8.0.1625.21506), X64 RyuJIT AVX2 [AttachedDebugger]
  DefaultJob : .NET 8.0.16 (8.0.1625.21506), X64 RyuJIT AVX2

@alastairlundy
Copy link
Contributor Author

@dotnet-policy-service agree

Copy link
Collaborator

@timcassell timcassell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll let @AndreyAkinshin be the final judge here.

Co-authored-by: Tim Cassell <[email protected]>
This was referenced Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Unknown processor" on Windows
3 participants