-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix "Unknown Processor" on Windows if WMIC is not present #2749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
timcassell
merged 70 commits into
dotnet:master
from
alastairlundy:fix-unknown-processor-windows
Jun 16, 2025
Merged
Fix "Unknown Processor" on Windows if WMIC is not present #2749
timcassell
merged 70 commits into
dotnet:master
from
alastairlundy:fix-unknown-processor-windows
Jun 16, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@dotnet-policy-service agree |
timcassell
reviewed
Jun 4, 2025
src/BenchmarkDotNet/Detectors/Cpu/Windows/WmiLightCpuDetector.cs
Outdated
Show resolved
Hide resolved
timcassell
reviewed
Jun 5, 2025
src/BenchmarkDotNet/Detectors/Cpu/Windows/WmiLightCpuDetector.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim Cassell <[email protected]>
timcassell
approved these changes
Jun 5, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I'll let @AndreyAkinshin be the final judge here.
AndreyAkinshin
requested changes
Jun 7, 2025
This reverts commit 5972f77.
…astairlundy/BenchmarkDotNet into fix-unknown-processor-windows
timcassell
reviewed
Jun 7, 2025
src/BenchmarkDotNet/Detectors/Cpu/Windows/PowershellWmiCpuDetector.cs
Outdated
Show resolved
Hide resolved
timcassell
reviewed
Jun 7, 2025
src/BenchmarkDotNet/Detectors/Cpu/Windows/PowershellWmiCpuDetector.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Tim Cassell <[email protected]>
This was referenced Sep 17, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #2747 by adding the
WmiLightCpuDetector
detector class that detects CPU info using the WmiLight library.This PR also updates
WmicCpuDetector
to also check for the presence of WMIC.exe at the expected file path to check for applicability so that it isn't used on systems without WMIC.exe .The output is as expected when tested. For testing I used the BenchmarkDotNet Samples project.