Skip to content

Add necessary space before "-r" extra argument for CoreRT #1951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add necessary space before "-r" extra argument for CoreRT #1951

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/BenchmarkDotNet/Toolchains/CoreRt/CoreRtToolchain.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ internal CoreRtToolchain(string displayName,
public static CoreRtToolchainBuilder CreateBuilder() => CoreRtToolchainBuilder.Create();

private static string GetExtraArguments(bool useCppCodeGenerator, string runtimeIdentifier)
=> useCppCodeGenerator ? $"-r {runtimeIdentifier} /p:NativeCodeGen=cpp" : $"-r {runtimeIdentifier}";
=> useCppCodeGenerator ? $" -r {runtimeIdentifier} /p:NativeCodeGen=cpp" : $" -r {runtimeIdentifier}";

// https://github.com/dotnet/corert/blob/7f902d4d8b1c3280e60f5e06c71951a60da173fb/Documentation/how-to-build-and-run-ilcompiler-in-console-shell-prompt.md#compiling-source-to-native-code-using-the-ilcompiler-you-built
// we have to pass IlcPath env var to get it working
Expand Down