Blazor native deps (w/callback coverage) #23668
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks @guardrex. |
41 tasks
SteveSandersonMS
approved these changes
Nov 11, 2021
Member
SteveSandersonMS
left a comment
SteveSandersonMS
left a comment
There was a problem hiding this comment.
I've made a bunch of suggestions but more broadly this looks great. Thanks @guardrex!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23661
Internal Review Topic
This guidance requires further work:
The
WasmBuildNativeproperty wasn't in the blog post. I guessed where/how to describe it.If an example makes sense for the callback guidance, place it in an issue comment here for inclusion.
I can't get the SkiaSharp example to work following this guidance with the GA SDK. AFAICT, this is local to my machine, but I'll need to test on another PC here to confirm. The example and guidance is straight out of the blog post AFAICT ...
https://devblogs.microsoft.com/dotnet/asp-net-core-updates-in-net-6-rc-2/#using-libraries-with-native-dependencies
The SkiaSharp repo example isn't an exact match to the scenario because it doesn't use the NuGet package.