-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Binding select multiple #22770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Binding select multiple #22770
Conversation
MackinnonBuck
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one small suggestion 😃
|
Also, no,
|
Co-authored-by: Mackinnon Buck <[email protected]>
|
Thanks @MackinnonBuck! 🎷 I'll hold this PR for Preview 7 release. |
Co-authored-by: Mackinnon Buck <[email protected]>
|
@MackinnonBuck ... This PR is blocking me from making other top priority updates for version-by-file (these topics need to move for that set of updates), so this PR has to go in now. I've added a line to each of the new sections that reads ...
... and I've made a note on the 6.0 tracking issue to remove that line when Preview 7 releases. |
Fixes #22448
Addresses #22448
🛑
HOLD FOR RELEASE OF PREVIEW 7🛑 We're going to go ahead with the coverage BUT with a comment that it applies to Preview 7. This is blocking other work. I'll revert the added comment when Preview 7 releases (tracked by the 6.0 tracking issue).On the PR:
nullbinding behavior section from the Forms Validation topic to the Data Binding topic and cross-links to it from Forms Validation. Cross-links also from each topic's new multiple select feature coverage.Question ❓:
For
InputSelect, themultipleattribute is inferred when bound to an array type. However, the example for binding<select>doesn't exhibit the same setup in the PU repo sample ...https://github.com/dotnet/aspnetcore/blob/main/src/Components/test/testassets/BasicTestApp/SelectVariantsComponent.razor
Is inferred
multiplea thing for binding<select>, too, and the sample just doesn't show it? If so, I'll mirror theInputSelectcoverage remark in the<select>coverage and probably modify the<select>coverage example to dropmultiplein that scenario, too (i.e., let it infer the attribute as theInputSelectexample does).