Skip to content

Conversation

@guardrex
Copy link
Collaborator

@guardrex guardrex commented Jul 19, 2021

Fixes #22448
Addresses #22448

🛑 HOLD FOR RELEASE OF PREVIEW 7 🛑 We're going to go ahead with the coverage BUT with a comment that it applies to Preview 7. This is blocking other work. I'll revert the added comment when Preview 7 releases (tracked by the 6.0 tracking issue).

On the PR:

  • The multiple select feature for Preview 7 release. I'll hold this PR until Preview 7 comes out.
  • Moves the null binding behavior section from the Forms Validation topic to the Data Binding topic and cross-links to it from Forms Validation. Cross-links also from each topic's new multiple select feature coverage.

Question ❓:

For InputSelect, the multiple attribute is inferred when bound to an array type. However, the example for binding <select> doesn't exhibit the same setup in the PU repo sample ...

https://github.com/dotnet/aspnetcore/blob/main/src/Components/test/testassets/BasicTestApp/SelectVariantsComponent.razor

Is inferred multiple a thing for binding <select>, too, and the sample just doesn't show it? If so, I'll mirror the InputSelect coverage remark in the <select> coverage and probably modify the <select> coverage example to drop multiple in that scenario, too (i.e., let it infer the attribute as the InputSelect example does).

@guardrex guardrex mentioned this pull request Jul 19, 2021
41 tasks
@guardrex guardrex requested a review from MackinnonBuck July 20, 2021 09:14
Copy link
Member

@MackinnonBuck MackinnonBuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one small suggestion 😃

@MackinnonBuck
Copy link
Member

MackinnonBuck commented Jul 22, 2021

Also, no, <select> does not infer multiple.

Is inferred multiple a thing for binding , too, and the sample just doesn't show it?

@guardrex
Copy link
Collaborator Author

guardrex commented Jul 22, 2021

Thanks @MackinnonBuck! 🎷

I'll hold this PR for Preview 7 release.

@guardrex guardrex marked this pull request as ready for review July 28, 2021 10:38
@guardrex
Copy link
Collaborator Author

@MackinnonBuck ... This PR is blocking me from making other top priority updates for version-by-file (these topics need to move for that set of updates), so this PR has to go in now. I've added a line to each of the new sections that reads ...

This feature applies to ASP.NET Core 6.0 Preview 7 or later. ASP.NET Core 6.0 is scheduled for release later this year.

... and I've made a note on the 6.0 tracking issue to remove that line when Preview 7 releases.

@guardrex guardrex merged commit fb681f3 into main Jul 28, 2021
@guardrex guardrex deleted the guardrex/blazor-select-multiple branch July 28, 2021 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blazor binding updates for 6.0

3 participants