-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Blazor byte array support #22718
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Blazor byte array support #22718
Conversation
|
Ahoy @TanayParikh! 🚢 ... I'm drafting the doc sections with examples for byte array interop:
Can you put an 👁️ on this PR at this early stage and see where the code is going to need a touch-up to make it work? If not, no worries. We can hold this PR in a draft state until I go on RC1 and then I'll work the 🐞 out of the code later. BTW: Ignore the |
TanayParikh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @guardrex for putting this together. This looks great!
Left some general comments, still need to put it in a project and double check it compiles / works as expected. (I'll try to get to this, this week).
aspnetcore/blazor/javascript-interoperability/call-dotnet-from-javascript.md
Outdated
Show resolved
Hide resolved
aspnetcore/blazor/javascript-interoperability/call-dotnet-from-javascript.md
Outdated
Show resolved
Hide resolved
aspnetcore/blazor/javascript-interoperability/call-dotnet-from-javascript.md
Outdated
Show resolved
Hide resolved
aspnetcore/blazor/javascript-interoperability/call-javascript-from-dotnet.md
Show resolved
Hide resolved
aspnetcore/blazor/javascript-interoperability/call-dotnet-from-javascript.md
Show resolved
Hide resolved
aspnetcore/blazor/javascript-interoperability/call-javascript-from-dotnet.md
Show resolved
Hide resolved
|
Thanks @TanayParikh ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @guardrex! Verified the sample code is working as expected (with the following minor change to encoding). Could we go ahead with merging/publishing these docs? The feature was just announced and I'm sure users will find this super helpful! 😄
Also, should we update the menu bar as well? Otherwise, if users just run the app they'll have to manually navigate to the newly created pages. Not sure if there's a general convention for this situation in the docs.
<div class="nav-item px-3">
<NavLink class="nav-link" href="send-byte-array-js-to-dotnet">
<span class="oi oi-arrow-right" aria-hidden="true"></span> JS to .NET Interop
</NavLink>
</div>
<div class="nav-item px-3">
<NavLink class="nav-link" href="send-byte-array-dotnet-to-js">
<span class="oi oi-arrow-left" aria-hidden="true"></span> .NET to JS Interop
</NavLink>
</div>
aspnetcore/blazor/javascript-interoperability/call-dotnet-from-javascript.md
Outdated
Show resolved
Hide resolved
…-javascript.md Co-authored-by: Tanay Parikh <[email protected]>
|
Thanks @TanayParikh ... We aren't showing navigation for every example later in the docs, such as at this point. It takes up too much space for little benefit. Early examples do show it (e.g., tutorials), and the Routing doc covers it in the Fundamentals node. We let those docs make devs aware of it. I was going to update the component naming to match the snippet sample app later, but I went ahead and did that now. These examples will be added to the snippet sample apps sometime after GA. The docs don't build preview releases, at least not yet. We might build doc examples for RC. No need to ping the others. They're all too busy to look at this 🏃😅. We worked out that the responsible engineer gets a single ping on these when the PR goes up. If they don't respond in a week or so, then Artak will look. He'll either be able to approve or reach out to the engineer for a look. In the end, I'm probably going to add a live doc coverage link to the topic section(s) for all of the 6.0 updates for a final management/engineer look before GA. For now tho, I only need your sign-off to merge, so I'll go ahead and get this in. |
Addresses #22444
Addresses #22045