-
Notifications
You must be signed in to change notification settings - Fork 25.1k
Enhance Blazor hosting model configuration content #19778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@guardrex Content here looks good. I wasn't able to reproduce the issue you cited. My repro steps are as follows:
This was on Is there a chance that you have a |
|
"Circuit" ... I expected to see the warning bar that a circuit hasn't been established. Turns out that there's no indication ... just everything that would depend on the circuit no-ops. Therefore, I'd like to look again at the text here. It should probably say somehow explicitly that "start" in |
|
@captainsafia ... Here's the latest opening remarks of that section ...
|
|
@captainsafia ... does this look good ☝️? |
captainsafia
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice additions! Left some feedback inline.
|
@captainsafia ... Confirm the CSS ... is this correct ... #components-reconnect-modal {
transition: visibility 0s linear 500ms;
}Nevermind ... got it ... looks correct based on dotnet/aspnetcore#24566. |
Fixes #15373
Internal Review Topic (links to section)
😕 ... I've run into a point of confusion that's even blocking this PR ...
Our content implies (and I was under the assumption) that when
autostart="false"is placed on the script that callingBlazor.start()is absolutely required to get the app going. Testing here seems to indicate that that's not so. When I set the_Host.cshtmlpage up with only the following ...and no call to
Blazor.start(), the app still starts and runs normally, which I don't expect to happen.What am I missing? ..... I'll adjust the PR accordingly to head off the (my 😄) confusion.