Fixes "strftime() expects parameter 2 to be integer, string given" PHP Warning, and PHP <7 compatibility issue. #46
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhenX
added a commit
that referenced
this pull request
Feb 14, 2016
Fixes "strftime() expects parameter 2 to be integer, string given" PHP Warning, and PHP <7 compatibility issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in PR #43 there was another warning, when the int being read was a string, and not just a float (which is what #43 fixed). Additionally, the fix uses PHP_INT_MIN, which I didn't realise only exists in PHP 7. I didn't notice it because I'm running it, but I did when I tested in other versions of PHP.