Skip to content

Conversation

@indreka
Copy link

@indreka indreka commented Feb 3, 2016

This should be the last part of the parsing optimizations, overall speedup on my machine (Win10, PHP 5.5) for loading FreeSerif font is now ~55%, 1.3s => 0.65s.

Indrek Altpere added 2 commits February 3, 2016 09:34
…along to init and parse functions, reduces overall parsing time by another 20% for FreeSerif
@PhenX
Copy link
Member

PhenX commented Feb 4, 2016

Great !
I didn't think inlining or passing as arguments could be so helpful. I see you like optimization, do you know blackfire.io ? I've been using it and it's really great.

@PhenX PhenX closed this Feb 4, 2016
@indreka
Copy link
Author

indreka commented Feb 5, 2016

I haven't used that, but it looks interesting :)

@indreka
Copy link
Author

indreka commented Feb 13, 2016

Hm, you closed this without merging. Was there some issue with the changes I suggested?

@PhenX
Copy link
Member

PhenX commented Feb 13, 2016

Whoops sorry

@PhenX PhenX reopened this Feb 13, 2016
PhenX added a commit that referenced this pull request Feb 13, 2016
Final patch of optimizations, giving additional 20% speedup
@PhenX PhenX merged commit 482ab8b into dompdf:master Feb 13, 2016
@indreka
Copy link
Author

indreka commented Feb 13, 2016

Awesome :)
I'm also sending some patches into Dompdf, hoping to achieve same level of optimization there also :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants