Fix order of class definition #12
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As indicated in the documentation on inheritance, PHP requires that classes be defined before they are used. In terms of a class that extends another class, the parent should be defined before the child. Earlier versions of PHP (and indeed the current version) may have been lenient on this point, but most opcache engines enforce the stricter ordering requirement. @url http://www.php.net/manual/en/language.oop5.inheritance.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As indicated in the documentation on inheritance, PHP
requires that classes be defined before they are used.
In terms of a class that extends another class, the
parent should be defined before the child. Earlier
versions of PHP (and indeed the current version) may
have been lenient on this point, but most opcache
engines enforce the stricter ordering requirement.
References: